From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pl1-x642.google.com ([2607:f8b0:4864:20::642]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1g7E1T-0001CX-Po for kexec@lists.infradead.org; Tue, 02 Oct 2018 06:19:09 +0000 Received: by mail-pl1-x642.google.com with SMTP id az3-v6so128377plb.4 for ; Mon, 01 Oct 2018 23:18:57 -0700 (PDT) Date: Tue, 2 Oct 2018 15:20:23 +0900 From: AKASHI Takahiro Subject: Re: [PATCH v15 04/16] powerpc, kexec_file: factor out memblock-based arch_kexec_walk_mem() Message-ID: <20181002062021.GE32578@linaro.org> References: <20180928064841.14117-1-takahiro.akashi@linaro.org> <20180928064841.14117-5-takahiro.akashi@linaro.org> <20180930100834.GD6950@dhcp-128-65.nay.redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20180930100834.GD6950@dhcp-128-65.nay.redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Dave Young Cc: linux-arm-kernel@lists.infradead.org, prudo@linux.ibm.com, herbert@gondor.apana.org.au, bhe@redhat.com, ard.biesheuvel@linaro.org, catalin.marinas@arm.com, bhsharma@redhat.com, will.deacon@arm.com, linux-kernel@vger.kernel.org, heiko.carstens@de.ibm.com, dhowells@redhat.com, arnd@arndb.de, "Eric W. Biederman" , kexec@lists.infradead.org, schwidefsky@de.ibm.com, james.morse@arm.com, davem@davemloft.net, vgoyal@redhat.com On Sun, Sep 30, 2018 at 06:08:34PM +0800, Dave Young wrote: > Hi AKASHI, > > On 09/28/18 at 03:48pm, AKASHI Takahiro wrote: > > Memblock list is another source for usable system memory layout. > > So move powerpc's arch_kexec_walk_mem() to common code so that other > > memblock-based architectures, particularly arm64, can also utilise it. > > A moved function is now renamed to kexec_walk_memblock() and integrated > > into kexec_locate_mem_hole(), which will now be usable for all > > architectures with no need for overriding arch_kexec_walk_mem(). > > > > With this change, arch_kexec_walk_mem() need no longer be a weak function, > > and was now renamed to kexec_walk_resources(). > > > > Since powerpc doesn't support kdump in its kexec_file_load(), the current > > kexec_walk_memblock() won't work for kdump either in this form, this will > > be fixed in the next patch. > > > > Signed-off-by: AKASHI Takahiro > > Cc: "Eric W. Biederman" > > Acked-by: Dave Young > > Cc: Vivek Goyal > > Cc: Baoquan He > > Acked-by: James Morse > > [snip] > > > + > > /** > > * arch_kexec_walk_mem - call func(data) on free memory regions > > The function name should be updated as well. Ah, thank you. -Takahiro Akashi > > * @kbuf: Context info for the search. Also passed to @func. > > @@ -510,8 +560,8 @@ static int locate_mem_hole_callback(struct resource *res, void *arg) > > * and that value will be returned. If all free regions are visited without > > * func returning non-zero, then zero will be returned. > > */ > > -int __weak arch_kexec_walk_mem(struct kexec_buf *kbuf, > > - int (*func)(struct resource *, void *)) > > +static int kexec_walk_resources(struct kexec_buf *kbuf, > > + int (*func)(struct resource *, void *)) > > { > > if (kbuf->image->type == KEXEC_TYPE_CRASH) > > return walk_iomem_res_desc(crashk_res.desc, > > @@ -538,7 +588,11 @@ int kexec_locate_mem_hole(struct kexec_buf *kbuf) > > if (kbuf->mem != KEXEC_BUF_MEM_UNKNOWN) > > return 0; > > > > - ret = arch_kexec_walk_mem(kbuf, locate_mem_hole_callback); > > + if (IS_ENABLED(CONFIG_HAVE_MEMBLOCK) && > > + !IS_ENABLED(CONFIG_ARCH_DISCARD_MEMBLOCK)) > > + ret = kexec_walk_memblock(kbuf, locate_mem_hole_callback); > > + else > > + ret = kexec_walk_resources(kbuf, locate_mem_hole_callback); > > > > return ret == 1 ? 0 : -EADDRNOTAVAIL; > > } > > -- > > 2.19.0 > > > > Thanks > Dave _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec