From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pg1-x544.google.com ([2607:f8b0:4864:20::544]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gM1qv-00053o-Mq for kexec@lists.infradead.org; Mon, 12 Nov 2018 02:21:27 +0000 Received: by mail-pg1-x544.google.com with SMTP id f8-v6so3327228pgq.5 for ; Sun, 11 Nov 2018 18:21:14 -0800 (PST) Date: Mon, 12 Nov 2018 11:24:07 +0900 From: AKASHI Takahiro Subject: Re: [PATCH] kexec/dt-ops.c: Fix check against 'fdt_add_subnode' return value Message-ID: <20181112022406.GZ11663@linaro.org> References: <1541968216-31282-1-git-send-email-bhsharma@redhat.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1541968216-31282-1-git-send-email-bhsharma@redhat.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Bhupesh Sharma Cc: bhupesh.linux@gmail.com, kexec@lists.infradead.org, Simon Horman T24gTW9uLCBOb3YgMTIsIDIwMTggYXQgMDI6MDA6MTZBTSArMDUzMCwgQmh1cGVzaCBTaGFybWEg d3JvdGU6Cj4gVmljZW7DpyByZXBvcnRlZCAodmlhIFsxXSkgdGhhdCBjdXJyZW50bHkgZXhlY3V0 aW5nIGtleGVjIHdpdGgKPiAnLS1kdGInIG9wdGlvbiBhbmQgcGFzc2luZyBhIC5kdGIgd2hpY2gg ZG9lc24ndCBoYXZlIGEgJy9jaG9zZW4nIG5vZGUKPiBsZWFkcyB0byB0aGUgZm9sbG93aW5nIGVy cm9yOgo+IAo+ICAgIyBrZXhlYyAtZCAtLWR0YiBkdGJfd2l0aG91dF9jaG9zZW5fbm9kZS5kdGIg LS1hcHBlbmQgJ2NtZGxpbmUnIC0tbG9hZCBJbWFnZQo+IAo+ICAgICBkdGJfc2V0X3Byb3BlcnR5 OiBmZHRfYWRkX3N1Ym5vZGUgZmFpbGVkOiA8dmFsaWQgb2Zmc2V0L2xlbmd0aD4KPiAgICAga2V4 ZWM6IFNldCBkZXZpY2UgdHJlZSBib290YXJncyBmYWlsZWQuCj4gCj4gVGhpcyBoYXBwZW5zIGJl Y2F1c2UgY3VycmVudGx5IHdlIGNoZWNrIHRoZSByZXR1cm4gdmFsdWUgb2YKPiAnZmR0X2FkZF9z dWJub2RlKCknIGZ1bmN0aW9uIGNhbGwgaW4gJ2R0LW9wcy5jJyBpbmNvcnJlY3RseToKPiAKPiAg ICByZXN1bHQgPSBmZHRfYWRkX3N1Ym5vZGUobmV3X2R0Yiwgbm9kZW9mZnNldCwgbm9kZSk7Cj4g ICAgaWYgKHJlc3VsdCkgewo+ICAgIAlkYmdwcmludGYoIiVzOiBmZHRfYWRkX3N1Ym5vZGUgZmFp bGVkOiAlc1xuIiwgX2Z1bmNfXywKPiAgICAJCWZkdF9zdHJlcnJvcihyZXN1bHQpKTsKPiAgICAJ Z290byBvbl9lcnJvcjsKPiAgICB9Cj4gCj4gQXMgd2UgY2FuIHNlZSBpbiAnZmR0X3J3LmMnLCBh IHBvc2l0aXZlIHJldHVybiB2YWx1ZSBmcm9tCj4gJ2ZkdF9hZGRfc3Vibm9kZSgpJyBmdW5jdGlv biBkb2Vzbid0IGluZGljYXRlIGFuIGVycm9yLgo+IAo+IFdlIGNhbiBzZWUgdGhhdCB0aGUgTGlu dXgga2VybmVsIChzZWUgJ2RyaXZlcnMvZmlybXdhcmUvZWZpL2xpYnN0dWIvZmR0LmMnCj4gZm9y IGV4YW1wbGUpIGFsc28gY2hlY2tzIHRoZSAnZmR0X2FkZF9zdWJub2RlKCknIGZ1bmN0aW9uIGFn YWluc3QgbmVnYXRpdmUKPiByZXR1cm4gdmFsdWVzIGZvciBlcnJvcnMuIFNlZSBhbiBleGFtcGxl IGJlbG93IGZyb20gJ3VwZGF0ZV9mZHQoKScgZnVuY3Rpb24gaW4KPiAnZHJpdmVycy9maXJtd2Fy ZS9lZmkvbGlic3R1Yi9mZHQuYyc6Cj4gCj4gICAgbm9kZSA9IGZkdF9hZGRfc3Vibm9kZShmZHQs IDAsICJjaG9zZW4iKTsKPiAgICBpZiAobm9kZSA8IDApIHsKPiAgICAJc3RhdHVzID0gbm9kZTsK PiAgICAJPC4uc25pcC4uPgo+ICAgIAlnb3RvIGZkdF9zZXRfZmFpbDsKPiAgICB9Cj4gCj4gVGhp cyBwYXRjaCBmaXhlcyB0aGUgc2FtZSBpbiAna2V4ZWMtdG9vbHMnLgoKTG9va3MgZ29vZC4KVGhh bmsgeW91LgotVGFrYWhpcm8gQWthc2hpCgo+IFsxXS4gaHR0cDovL2xpc3RzLmluZnJhZGVhZC5v cmcvcGlwZXJtYWlsL2tleGVjLzIwMTgtT2N0b2Jlci8wMjE3NDYuaHRtbAo+IAo+IENjOiBTaW1v biBIb3JtYW4gPGhvcm1zQHZlcmdlLm5ldC5hdT4KPiBDYzogQUtBU0hJIFRha2FoaXJvIDx0YWth aGlyby5ha2FzaGlAbGluYXJvLm9yZz4KPiBSZXBvcnRlZC1ieTogVmljZW50ZSBCZXJnYXMgPHZp Y2VuY2JAZ21haWwuY29tPgo+IFNpZ25lZC1vZmYtYnk6IEJodXBlc2ggU2hhcm1hIDxiaHNoYXJt YUByZWRoYXQuY29tPgo+IC0tLQo+ICBrZXhlYy9kdC1vcHMuYyB8IDIgKy0KPiAgMSBmaWxlIGNo YW5nZWQsIDEgaW5zZXJ0aW9uKCspLCAxIGRlbGV0aW9uKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2tl eGVjL2R0LW9wcy5jIGIva2V4ZWMvZHQtb3BzLmMKPiBpbmRleCA5MTVkYmY1NWFmZDIuLmYxNTE3 NGMzYzc0ZSAxMDA2NDQKPiAtLS0gYS9rZXhlYy9kdC1vcHMuYwo+ICsrKyBiL2tleGVjL2R0LW9w cy5jCj4gQEAgLTg0LDcgKzg0LDcgQEAgaW50IGR0Yl9zZXRfcHJvcGVydHkoY2hhciAqKmR0Yiwg b2ZmX3QgKmR0Yl9zaXplLCBjb25zdCBjaGFyICpub2RlLAo+ICAJaWYgKG5vZGVvZmZzZXQgPT0g LUZEVF9FUlJfTk9URk9VTkQpIHsKPiAgCQlyZXN1bHQgPSBmZHRfYWRkX3N1Ym5vZGUobmV3X2R0 Yiwgbm9kZW9mZnNldCwgbm9kZSk7Cj4gIAo+IC0JCWlmIChyZXN1bHQpIHsKPiArCQlpZiAocmVz dWx0IDwgMCkgewo+ICAJCQlkYmdwcmludGYoIiVzOiBmZHRfYWRkX3N1Ym5vZGUgZmFpbGVkOiAl c1xuIiwgX19mdW5jX18sCj4gIAkJCQlmZHRfc3RyZXJyb3IocmVzdWx0KSk7Cj4gIAkJCWdvdG8g b25fZXJyb3I7Cj4gLS0gCj4gMi43LjQKPiAKCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fCmtleGVjIG1haWxpbmcgbGlzdAprZXhlY0BsaXN0cy5pbmZyYWRl YWQub3JnCmh0dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8va2V4ZWMK