From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1gMEne-0006T2-8J for kexec@lists.infradead.org; Mon, 12 Nov 2018 16:10:56 +0000 Received: by mail-wm1-x344.google.com with SMTP id w7-v6so9051030wmc.1 for ; Mon, 12 Nov 2018 08:10:42 -0800 (PST) From: Vicente Bergas Subject: [PATCH] kexec/dt-ops.c: Fix check against 'fdt_add_subnode' return value Date: Mon, 12 Nov 2018 17:10:31 +0100 Message-Id: <20181112161031.14343-1-vicencb@gmail.com> In-Reply-To: 1541968216-31282-1-git-send-email-bhsharma@redhat.com References: CACi5LpPi9NUxfiqKXScEznnYEKyGEm21Qtdk-3XQ0OUGy+7epQ@mail.gmail.com MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: bhsharma@redhat.com Cc: takahiro.akashi@linaro.org, horms@verge.net.au, kexec@lists.infradead.org T24gTW9uLCAxMiBOb3YgMjAxOCAwMjowMDoxNiArMDUzMCwgQmh1cGVzaCBTaGFybWEgd3JvdGU6 Cj4gVmljZW7DpyByZXBvcnRlZCAodmlhIFsxXSkgdGhhdCBjdXJyZW50bHkgZXhlY3V0aW5nIGtl eGVjIHdpdGgKPiAnLS1kdGInIG9wdGlvbiBhbmQgcGFzc2luZyBhIC5kdGIgd2hpY2ggZG9lc24n dCBoYXZlIGEgJy9jaG9zZW4nIG5vZGUKPiBsZWFkcyB0byB0aGUgZm9sbG93aW5nIGVycm9yOgo+ IAo+ICAgIyBrZXhlYyAtZCAtLWR0YiBkdGJfd2l0aG91dF9jaG9zZW5fbm9kZS5kdGIgLS1hcHBl bmQgJ2NtZGxpbmUnIC0tbG9hZCBJbWFnZQo+IAo+ICAgICBkdGJfc2V0X3Byb3BlcnR5OiBmZHRf YWRkX3N1Ym5vZGUgZmFpbGVkOiA8dmFsaWQgb2Zmc2V0L2xlbmd0aD4KPiAgICAga2V4ZWM6IFNl dCBkZXZpY2UgdHJlZSBib290YXJncyBmYWlsZWQuCj4gCj4gVGhpcyBoYXBwZW5zIGJlY2F1c2Ug Y3VycmVudGx5IHdlIGNoZWNrIHRoZSByZXR1cm4gdmFsdWUgb2YKPiAnZmR0X2FkZF9zdWJub2Rl KCknIGZ1bmN0aW9uIGNhbGwgaW4gJ2R0LW9wcy5jJyBpbmNvcnJlY3RseToKPiAKPiAgICByZXN1 bHQgPSBmZHRfYWRkX3N1Ym5vZGUobmV3X2R0Yiwgbm9kZW9mZnNldCwgbm9kZSk7Cj4gICAgaWYg KHJlc3VsdCkgewo+ICAgIAlkYmdwcmludGYoIiVzOiBmZHRfYWRkX3N1Ym5vZGUgZmFpbGVkOiAl c1xuIiwgX2Z1bmNfXywKPiAgICAJCWZkdF9zdHJlcnJvcihyZXN1bHQpKTsKPiAgICAJZ290byBv bl9lcnJvcjsKPiAgICB9Cj4gCj4gQXMgd2UgY2FuIHNlZSBpbiAnZmR0X3J3LmMnLCBhIHBvc2l0 aXZlIHJldHVybiB2YWx1ZSBmcm9tCj4gJ2ZkdF9hZGRfc3Vibm9kZSgpJyBmdW5jdGlvbiBkb2Vz bid0IGluZGljYXRlIGFuIGVycm9yLgo+IAo+IFdlIGNhbiBzZWUgdGhhdCB0aGUgTGludXgga2Vy bmVsIChzZWUgJ2RyaXZlcnMvZmlybXdhcmUvZWZpL2xpYnN0dWIvZmR0LmMnCj4gZm9yIGV4YW1w bGUpIGFsc28gY2hlY2tzIHRoZSAnZmR0X2FkZF9zdWJub2RlKCknIGZ1bmN0aW9uIGFnYWluc3Qg bmVnYXRpdmUKPiByZXR1cm4gdmFsdWVzIGZvciBlcnJvcnMuIFNlZSBhbiBleGFtcGxlIGJlbG93 IGZyb20gJ3VwZGF0ZV9mZHQoKScgZnVuY3Rpb24gaW4KPiAnZHJpdmVycy9maXJtd2FyZS9lZmkv bGlic3R1Yi9mZHQuYyc6Cj4gCj4gICAgbm9kZSA9IGZkdF9hZGRfc3Vibm9kZShmZHQsIDAsICJj aG9zZW4iKTsKPiAgICBpZiAobm9kZSA8IDApIHsKPiAgICAJc3RhdHVzID0gbm9kZTsKPiAgICAJ PC4uc25pcC4uPgo+ICAgIAlnb3RvIGZkdF9zZXRfZmFpbDsKPiAgICB9Cj4gCj4gVGhpcyBwYXRj aCBmaXhlcyB0aGUgc2FtZSBpbiAna2V4ZWMtdG9vbHMnLgoKVGhlIHBhdGNoIGxvb2tzIGZpbmUs IGJ1dCB0aGUgZW5kIHJlc3VsdCBpcyBzdGlsbCBub24td29ya2luZzoKICAjIGtleGVjIC1kIC0t bG9hZCBJbWFnZSAtLWFwcGVuZCAnZGVidWcnIC0tZHRiIG5vX2Nob3Nlbi5kdGIgCiAgLi4uCiAg ZHRiX3NldF9wcm9wZXJ0eTogZmR0X3NldHByb3AgZmFpbGVkOiBGRFRfRVJSX0JBRE9GRlNFVAog IGtleGVjOiBTZXQgZGV2aWNlIHRyZWUgYm9vdGFyZ3MgZmFpbGVkLgoKQWxzbyB0ZXN0ZWQgdGhp cyB3aXRoIHRoZSBzYW1lIHJlc3VsdDoKLS0tIGEva2V4ZWMvZHQtb3BzLmMKKysrIGIva2V4ZWMv ZHQtb3BzLmMKQEAgLTg0LDExICs4NCwxMyBAQAogCWlmIChub2Rlb2Zmc2V0ID09IC1GRFRfRVJS X05PVEZPVU5EKSB7CiAJCXJlc3VsdCA9IGZkdF9hZGRfc3Vibm9kZShuZXdfZHRiLCBub2Rlb2Zm c2V0LCBub2RlKTsKIAotCQlpZiAocmVzdWx0KSB7CisJCWlmIChyZXN1bHQgPCAwKSB7CiAJCQlk YmdwcmludGYoIiVzOiBmZHRfYWRkX3N1Ym5vZGUgZmFpbGVkOiAlc1xuIiwgX19mdW5jX18sCiAJ CQkJZmR0X3N0cmVycm9yKHJlc3VsdCkpOwogCQkJZ290byBvbl9lcnJvcjsKIAkJfQorCisJCW5v ZGVvZmZzZXQgPSByZXN1bHQ7CiAJfSBlbHNlIGlmIChub2Rlb2Zmc2V0IDwgMCkgewogCQlkYmdw cmludGYoIiVzOiBmZHRfcGF0aF9vZmZzZXQgZmFpbGVkOiAlc1xuIiwgX19mdW5jX18sCiAJCQlm ZHRfc3RyZXJyb3Iobm9kZW9mZnNldCkpOwoKUmVnYXJkcywKICBWaWNlbsOnLgoKPiBbMV0uIGh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL3BpcGVybWFpbC9rZXhlYy8yMDE4LU9jdG9iZXIvMDIx NzQ2Lmh0bWwKPiAKPiBDYzogU2ltb24gSG9ybWFuIDxob3Jtc0B2ZXJnZS5uZXQuYXU+Cj4gQ2M6 IEFLQVNISSBUYWthaGlybyA8dGFrYWhpcm8uYWthc2hpQGxpbmFyby5vcmc+Cj4gUmVwb3J0ZWQt Ynk6IFZpY2VudGUgQmVyZ2FzIDx2aWNlbmNiQGdtYWlsLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBC aHVwZXNoIFNoYXJtYSA8YmhzaGFybWFAcmVkaGF0LmNvbT4KPiAtLS0KPiAga2V4ZWMvZHQtb3Bz LmMgfCAyICstCj4gIDEgZmlsZSBjaGFuZ2VkLCAxIGluc2VydGlvbigrKSwgMSBkZWxldGlvbigt KQo+IAo+IGRpZmYgLS1naXQgYS9rZXhlYy9kdC1vcHMuYyBiL2tleGVjL2R0LW9wcy5jCj4gaW5k ZXggOTE1ZGJmNTVhZmQyLi5mMTUxNzRjM2M3NGUgMTAwNjQ0Cj4gLS0tIGEva2V4ZWMvZHQtb3Bz LmMKPiArKysgYi9rZXhlYy9kdC1vcHMuYwo+IEBAIC04NCw3ICs4NCw3IEBAIGludCBkdGJfc2V0 X3Byb3BlcnR5KGNoYXIgKipkdGIsIG9mZl90ICpkdGJfc2l6ZSwgY29uc3QgY2hhciAqbm9kZSwK PiAgCWlmIChub2Rlb2Zmc2V0ID09IC1GRFRfRVJSX05PVEZPVU5EKSB7Cj4gIAkJcmVzdWx0ID0g ZmR0X2FkZF9zdWJub2RlKG5ld19kdGIsIG5vZGVvZmZzZXQsIG5vZGUpOwo+ICAKPiAtCQlpZiAo cmVzdWx0KSB7Cj4gKwkJaWYgKHJlc3VsdCA8IDApIHsKPiAgCQkJZGJncHJpbnRmKCIlczogZmR0 X2FkZF9zdWJub2RlIGZhaWxlZDogJXNcbiIsIF9fZnVuY19fLAo+ICAJCQkJZmR0X3N0cmVycm9y KHJlc3VsdCkpOwo+ICAJCQlnb3RvIG9uX2Vycm9yOwo+IC0tIAo+IDIuNy40CgpfX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwprZXhlYyBtYWlsaW5nIGxpc3QK a2V4ZWNAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRwOi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWls bWFuL2xpc3RpbmZvL2tleGVjCg==