From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Date: Thu, 6 Dec 2018 15:54:24 +0000 From: Will Deacon Subject: Re: [PATCH v16 06/16] lib: fdt: add a helper function for handling memory range property Message-ID: <20181206155424.GA4422@arm.com> References: <20181115055254.2812-1-takahiro.akashi@linaro.org> <20181115055254.2812-7-takahiro.akashi@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Rob Herring Cc: prudo@linux.ibm.com, Herbert Xu , Baoquan He , Ard Biesheuvel , Catalin Marinas , bhsharma@redhat.com, Frank Rowand , Heiko Carstens , "linux-kernel@vger.kernel.org" , David Howells , "AKASHI, Takahiro" , devicetree@vger.kernel.org, Arnd Bergmann , "moderated list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE" , kexec@lists.infradead.org, Martin Schwidefsky , James Morse , dyoung@redhat.com, David Miller , Vivek Goyal Hi Rob, Thanks for reviewing this. On Thu, Dec 06, 2018 at 08:47:04AM -0600, Rob Herring wrote: > On Wed, Nov 14, 2018 at 11:52 PM AKASHI Takahiro > wrote: > > > > Added function, fdt_setprop_reg(), will be used later to handle > > kexec-specific property in arm64's kexec_file implementation. > > It will possibly be merged into libfdt in the future. > > You generally can't modify libfdt files. Any changes will be blown > away with the next dtc sync (there's one in -next now). Though here > you are creating a new location with fdt code. lib/ is just a shim to > the actual libfdt code. Don't put any implementation there. You can > add this to drivers/of/fdt_address.c for the short term, but it still > needs to go upstream. > > Otherwise, the implementation looks fine to me. I agree, but I don't think there's a real need for us to hack drivers/of/fdt_address.c in the meantime -- let's just target upstream and not carry this in the kernel. Akashi -- for now, I'll drop the kdump parts of this series which rely on this helper. The majority of the series is actually independent and can go in as-is. I've pushed out a kexec branch to the arm64 tree for you to take a look at: https://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git/log/?h=kexec Thanks, Will _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec