From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: From: James Morse Subject: [PATCH arm64/kexec] arm64: kexec_file: forbid kdump via kexec_file_load() Date: Fri, 7 Dec 2018 10:14:39 +0000 Message-Id: <20181207101439.190918-1-james.morse@arm.com> MIME-Version: 1.0 List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: linux-arm-kernel@lists.infradead.org Cc: devicetree@vger.kernel.org, Herbert Xu , Baoquan He , Ard Biesheuvel , Will Deacon , bhsharma@redhat.com, Frank Rowand , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Heiko Carstens , David Howells , AKASHI Takahiro , Rob Herring , Arnd Bergmann , James Morse , Catalin Marinas , Martin Schwidefsky , prudo@linux.ibm.com, dyoung@redhat.com, David Miller , Vivek Goyal Now that kexec_walk_memblock() can do the crash-kernel placement itself architectures that don't support kdump via kexe_file_load() need to explicitly forbid it. We don't support this on arm64 until the kernel can add the elfcorehdr and usable-memory-range fields to the DT. Without these the crash-kernel overwrites the previous kernel's memory during startup. Add a check to refuse crash image loading. Signed-off-by: James Morse --- Context: http://lore.kernel.org/r/20181206155424.GA4422@arm.com arch/arm64/kernel/kexec_image.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/arm64/kernel/kexec_image.c b/arch/arm64/kernel/kexec_image.c index 1ad1d5f8f024..07bf740bea91 100644 --- a/arch/arm64/kernel/kexec_image.c +++ b/arch/arm64/kernel/kexec_image.c @@ -47,6 +47,10 @@ static void *image_load(struct kimage *image, struct kexec_segment *kernel_segment; int ret; + /* We don't support crash kernels yet. */ + if (image->type == KEXEC_TYPE_CRASH) + return ERR_PTR(-EOPNOTSUPP); + /* * We require a kernel with an unambiguous Image header. Per * Documentation/booting.txt, this is the case when image_size -- 2.19.2 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec