From: Borislav Petkov <bp@alien8.de>
To: Kairui Song <kasong@redhat.com>
Cc: rafael.j.wysocki@intel.com, Baoquan He <bhe@redhat.com>,
erik.schmauss@intel.com, x86@kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
robert.moore@intel.com, mingo@redhat.com, hpa@zytor.com,
tglx@linutronix.de, Dave Young <dyoung@redhat.com>,
akpm@linux-foundation.org, Chao Fan <fanc.fnst@cn.fujitsu.com>,
Len Brown <lenb@kernel.org>
Subject: Re: [PATCH v2 2/2] x86, kexec_file_load: make it work with efi=noruntime or efi=old_map
Date: Wed, 16 Jan 2019 10:46:19 +0100 [thread overview]
Message-ID: <20190116094619.GB15409@zn.tnic> (raw)
In-Reply-To: <CACPcB9dYD2zR7ssXFibkefo3EZuvVnLegovwTMA8MaaLP1UsYQ@mail.gmail.com>
On Wed, Jan 16, 2019 at 03:08:42PM +0800, Kairui Song wrote:
> I didn't see a way to reuse things in that patch series, situation is
> different, in that patch it needs to get RSDP in very early boot stage
> so it did everything from scratch, in this patch kexec_file_load need
> to get RSDP too, but everything is well setup so things are a lot
> easier, just read from current boot_prams, efi and fallback to
> acpi_find_root_pointer should be good.
No no. Early code should find out that venerable RSDP thing once and
will save it somewhere for further use. No gazillion parsings of it.
Just once and share it with the rest of the code that needs it.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-01-16 9:46 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 9:58 [PATCH 0/2] make kexec work with efi=noruntime or efi=old_map Kairui Song
2019-01-15 9:58 ` [PATCH v2 1/2] x86, kexec_file_load: Don't setup EFI info if EFI runtime is not enabled Kairui Song
2019-01-15 9:58 ` [PATCH v2 2/2] x86, kexec_file_load: make it work with efi=noruntime or efi=old_map Kairui Song
2019-01-15 23:10 ` Borislav Petkov
2019-01-16 3:32 ` Dave Young
2019-01-16 5:09 ` Kairui Song
2019-01-16 6:51 ` Dave Young
2019-01-16 22:24 ` Rafael J. Wysocki
2019-01-16 7:08 ` Kairui Song
2019-01-16 9:46 ` Borislav Petkov [this message]
2019-01-17 7:41 ` Kairui Song
2019-01-17 7:49 ` Chao Fan
2019-01-17 8:20 ` Kairui Song
2019-01-17 8:54 ` Dave Young
2019-01-17 8:53 ` Dave Young
2019-01-17 9:39 ` Rafael J. Wysocki
2019-01-18 4:47 ` Kairui Song
2019-01-18 9:45 ` Rafael J. Wysocki
2019-01-18 10:26 ` Borislav Petkov
2019-01-21 1:18 ` Chao Fan
2019-01-21 8:29 ` Borislav Petkov
2019-01-21 8:43 ` Chao Fan
2019-01-21 9:19 ` Borislav Petkov
2019-01-22 3:32 ` Chao Fan
2019-01-22 12:17 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190116094619.GB15409@zn.tnic \
--to=bp@alien8.de \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=erik.schmauss@intel.com \
--cc=fanc.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=kasong@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rafael.j.wysocki@intel.com \
--cc=robert.moore@intel.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox