From: Dave Young <dyoung@redhat.com>
To: Kairui Song <kasong@redhat.com>
Cc: Simon Horman <horms@verge.net.au>, kexec@lists.infradead.org
Subject: Re: [PATCH] x86: Introdudce a new option --force-vga
Date: Tue, 5 Mar 2019 18:09:07 +0800 [thread overview]
Message-ID: <20190305100907.GA8622@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <CACPcB9dqSH9DKJTCzJOW6asX0k5LsMCph27DD0hZFanppygZ0A@mail.gmail.com>
On 03/05/19 at 04:24pm, Kairui Song wrote:
> On Mon, Mar 4, 2019 at 2:30 PM Dave Young <dyoung@redhat.com> wrote:
> >
> > On 02/28/19 at 06:07pm, Kairui Song wrote:
> > > After commit 060eee58 "x86: use old screen_info if needed", kexec-tools
> > > will force use old screen_info and vga type if failed to determine
> > > current vga type. But it is not always a good idea.
> > >
> > > Currently kernel hanging is inspected on some hyper-v VMs after this
> > > commit, because hyperv_fb will mimic EFI (or VESA) VGA on first boot
> > > up, but after the real driver is loaded, it will switch to new mode
> > > and no longer compatible with EFI/VESA VGA. Keep setting
> > > orig_video_isVGA to EFI/VESA VGA flag will get wrong driver loaded and
> > > try to manipulate the framebuffer in a wrong way.
> > >
> > > We can't ensure this won't happen on other framebuffer drivers, But
> > > it's a helpful feature if the framebuffer drivers just work. So this
> > > patch introduce a --force-vga options to let user decide if the
> > > old screen_info should be used unconditional or not.
> >
> > It looks good to me except the option name, because vga usually means
> > the specific vga video type. But here you are enforcing to reuse the first
> > kernel original video type.
> >
> > It would be better to use --reuse-video-type or --force-orig-video, etc..
> >
>
> Thanks for the review, the naming is not very good indeed, will update
> the patch. How about just --reuse-video? This should be general enough
> and clear.
Hmm, I feel --reuse-video-type is clearer, --reuse-video seems not
clear :)
>
> --
> Best Regards,
> Kairui Song
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-03-05 10:09 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-28 10:07 [PATCH] x86: Introdudce a new option --force-vga Kairui Song
2019-03-04 6:30 ` Dave Young
2019-03-05 8:24 ` Kairui Song
2019-03-05 10:09 ` Dave Young [this message]
2019-03-05 10:17 ` Kairui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190305100907.GA8622@dhcp-128-65.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=horms@verge.net.au \
--cc=kasong@redhat.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox