From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.skyhub.de ([2a01:4f8:190:11c2::b:1457]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h8OIY-0001Ge-0E for kexec@lists.infradead.org; Mon, 25 Mar 2019 12:01:52 +0000 Date: Mon, 25 Mar 2019 13:01:49 +0100 From: Borislav Petkov Subject: Re: [PATCH v2] x86/boot: Use EFI setup data if provided Message-ID: <20190325120149.GI12016@zn.tnic> References: <20190322152328.GD12472@zn.tnic> <20190325002740.GA6637@jeru.linux.bs1.fc.nec.co.jp> <20190325060128.GB9385@dhcp-128-65.nay.redhat.com> <20190325061929.GC9385@dhcp-128-65.nay.redhat.com> <20190325065921.GA11096@dhcp-128-65.nay.redhat.com> <20190325082720.GA20771@jeru.linux.bs1.fc.nec.co.jp> <51D9A7D1-49BF-4679-B102-0FC5AC300C9F@alien8.de> <20190325101509.GA13160@dhcp-128-65.nay.redhat.com> <701c8e69-e1d4-c653-1d87-1c41789d3d54@ce.jp.nec.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <701c8e69-e1d4-c653-1d87-1c41789d3d54@ce.jp.nec.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Junichi Nomura Cc: "fanc.fnst@cn.fujitsu.com" , "kasong@redhat.com" , "bhe@redhat.com" , "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Dave Young On Mon, Mar 25, 2019 at 10:36:33AM +0000, Junichi Nomura wrote: > AFAIU, early parsing is new code in v5.1-rc1 to support kexec on systems > with hotpluggable memory with KASLR enabled. For systems that requires the > new feature, it may be ok to say "you need to use another kexec interface" > and/or "you need new kexec-tools". No, this exactly should *not* happen. kexec is already full of duct tape - don't need any more of that. So I suggested that efi_get_rsdp_addr() should exit early on in the kexeced kernel but making this all play nice with the kexec-ed kernel, as Dave suggests, is better. Now, my next question is: why does the RDSP address need to come from kexec(1) (by way of efi_setup_data) and why can't the kexec'ed kernel figure it out itself by parsing the EFI tables in a similar way to efi_get_rsdp_addr ? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec