From: Borislav Petkov <bp@alien8.de>
To: lijiang <lijiang@redhat.com>
Cc: Thomas.Lendacky@amd.com, x86@kernel.org, bhe@redhat.com,
peterz@infradead.org, dave.hansen@linux.intel.com,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
mingo@redhat.com, luto@kernel.org, hpa@zytor.com,
tglx@linutronix.de, dyoung@redhat.com, akpm@linux-foundation.org
Subject: Re: [PATCH 2/3 v9] resource: add the new I/O resource descriptor 'IORES_DESC_RESERVED'
Date: Mon, 25 Mar 2019 13:24:26 +0100 [thread overview]
Message-ID: <20190325122426.GK12016@zn.tnic> (raw)
In-Reply-To: <47bfcbe2-1631-9733-74c2-fb3e56540052@redhat.com>
On Mon, Mar 25, 2019 at 02:53:02PM +0800, lijiang wrote:
> In this function, i printed its values, and only got the value of reserved
> type, so i changed the IORES_DESC_NONE to the IORES_DESC_RESERVED.
>
> In addition, after the new descriptor 'IORES_DESC_RESERVED' is introduced,
> the IORES_DESC_NONE does not include the IORES_DESC_RESERVED any more, it
> could miss to handle the value of the reserved type.
Yes, IORES_DESC_RESERVED is supposed to denote the e820 reserved type.
Why should IORES_DESC_NONE include it ?!?!
IORES_DESC_NONE is, well, an invalid, i.e., "none" type:
/*
* I/O Resource Descriptors
*
* Descriptors are used by walk_iomem_res_desc() and region_intersects()
* for searching a specific resource range in the iomem table. Assign
* a new descriptor when a resource range supports the search interfaces.
* Otherwise, resource.desc must be set to IORES_DESC_NONE (0).
*/
> Do you mean i should never touch the three chunks? If i made a mistake, i
> will remove this changes next post.
I'm looking at the hunks below and you're changing ->desc assignments in
some random function which doesn't look like you know what you're doing.
Maybe it gets you what you want but it sure as hell doesn't look right
to me.
--
Regards/Gruss,
Boris.
Good mailing practices for 400: avoid top-posting and trim the reply.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-03-25 12:24 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-21 10:33 [PATCH 0/3 v9] add reserved e820 ranges to the kdump kernel e820 table Lianbo Jiang
2019-03-21 10:33 ` [PATCH 1/3 v9] x86/mm: Change the examination condition to avoid confusion Lianbo Jiang
2019-03-22 17:51 ` Borislav Petkov
2019-03-25 3:11 ` lijiang
2019-03-25 6:40 ` Borislav Petkov
2019-03-25 9:20 ` lijiang
2019-03-25 12:15 ` Borislav Petkov
2019-03-21 10:33 ` [PATCH 2/3 v9] resource: add the new I/O resource descriptor 'IORES_DESC_RESERVED' Lianbo Jiang
2019-03-22 19:28 ` Borislav Petkov
2019-03-25 6:53 ` lijiang
2019-03-25 12:24 ` Borislav Petkov [this message]
2019-03-28 14:00 ` lijiang
2019-03-21 10:33 ` [PATCH 3/3 v9] x86/kexec_file: add reserved e820 ranges to kdump kernel e820 table Lianbo Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190325122426.GK12016@zn.tnic \
--to=bp@alien8.de \
--cc=Thomas.Lendacky@amd.com \
--cc=akpm@linux-foundation.org \
--cc=bhe@redhat.com \
--cc=dave.hansen@linux.intel.com \
--cc=dyoung@redhat.com \
--cc=hpa@zytor.com \
--cc=kexec@lists.infradead.org \
--cc=lijiang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox