From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.skyhub.de ([5.9.137.197]) by bombadil.infradead.org with esmtps (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9n2r-0007J4-1J for kexec@lists.infradead.org; Fri, 29 Mar 2019 08:39:26 +0000 Date: Fri, 29 Mar 2019 09:39:20 +0100 From: Borislav Petkov Subject: Re: [PATCH v2] x86/boot: Use EFI setup data if provided Message-ID: <20190329083920.GA21152@zn.tnic> References: <20190325122302.GC13160@dhcp-128-65.nay.redhat.com> <20190325123229.GL12016@zn.tnic> <20190325231000.GA9184@jeru.linux.bs1.fc.nec.co.jp> <20190326135714.GG1867@zn.tnic> <20190327014852.GA3659@MiWiFi-R3L-srv> <73322ba9-e436-68db-7863-afd31607d969@ce.jp.nec.com> <20190328064343.GA1877@MiWiFi-R3L-srv> <20190328074337.GA9470@jeru.linux.bs1.fc.nec.co.jp> <20190328155256.GP22720@zn.tnic> <0263068e-f2d0-1101-0438-0f570f0b38e7@ce.jp.nec.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <0263068e-f2d0-1101-0438-0f570f0b38e7@ce.jp.nec.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Junichi Nomura , "fanc.fnst@cn.fujitsu.com" Cc: "kasong@redhat.com" , "bhe@redhat.com" , "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Dave Young On Fri, Mar 29, 2019 at 03:05:52AM +0000, Junichi Nomura wrote: > > You don't need that variable and can return "table" or 0 after the endif > > below. > > I could do that but it will slightly change the current logic. > > Existing code does this: > > if (!(efi_guidcmp(guid, ACPI_TABLE_GUID))) > rsdp_addr = table; > else if (!(efi_guidcmp(guid, ACPI_20_TABLE_GUID))) > return table; > > I thought it was to return the table for ACPI_20_TABLE_GUID > if both tables exist. If we remove rsdp_addr, the code will be: > > if (!(efi_guidcmp(guid, ACPI_TABLE_GUID))) > return table; > else if (!(efi_guidcmp(guid, ACPI_20_TABLE_GUID))) > return table; > > So if there are 2 tables, we return the one that comes first. > Is it ok? That's a good question. Chao, what was the intention there, ACPI_20_TABLE_GUID is the preferred table to return? If so, why? -- Regards/Gruss, Boris. Good mailing practices for 400: avoid top-posting and trim the reply. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec