From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.cn.fujitsu.com ([183.91.158.132] helo=heian.cn.fujitsu.com) by bombadil.infradead.org with esmtp (Exim 4.90_1 #2 (Red Hat Linux)) id 1h9nfp-0005E6-Ez for kexec@lists.infradead.org; Fri, 29 Mar 2019 09:19:42 +0000 Date: Fri, 29 Mar 2019 17:18:50 +0800 From: Chao Fan Subject: Re: [PATCH] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Message-ID: <20190329091850.GJ4234@localhost.localdomain> References: <20190325231000.GA9184@jeru.linux.bs1.fc.nec.co.jp> <20190326135714.GG1867@zn.tnic> <20190327014852.GA3659@MiWiFi-R3L-srv> <73322ba9-e436-68db-7863-afd31607d969@ce.jp.nec.com> <20190328064343.GA1877@MiWiFi-R3L-srv> <20190328074337.GA9470@jeru.linux.bs1.fc.nec.co.jp> <20190328155256.GP22720@zn.tnic> <20190329072037.GA5840@jeru.linux.bs1.fc.nec.co.jp> <20190329082929.GH4234@localhost.localdomain> <5dba5878-4bc7-e9cd-134d-ce88e8b6a766@ce.jp.nec.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <5dba5878-4bc7-e9cd-134d-ce88e8b6a766@ce.jp.nec.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Junichi Nomura Cc: "kasong@redhat.com" , "bhe@redhat.com" , "x86@kernel.org" , "kexec@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Borislav Petkov , Dave Young On Fri, Mar 29, 2019 at 08:39:45AM +0000, Junichi Nomura wrote: >On 3/29/19 5:29 PM, Chao Fan wrote: >> On Fri, Mar 29, 2019 at 07:20:38AM +0000, Junichi Nomura wrote: >>> + return __efi_get_rsdp_addr(config_tables, nr_tables, efi_64); >>> +#else >>> + return 0; >>> #endif >>> - return rsdp_addr; >> >> I remeber the rsdp_addr is defined before #ifdef CONFIG_EFI >> If so, you don't need >> #else >> return 0; > >I moved the whole __efi_get_rsdp_addr() to the inside of #ifdef CONFIG_EFI >and both kexec_get_rsdp_addr() and efi_get_rsdp_addr() just return 0 if >CONFIG_EFI is not defined. Ah, got it. I will add the patch and do a simple test. > >> BY the way, what's your patch based on? I like add patch on my local >> branch and then review code, but failed. >> I try to use 'patch -p1 <' your patch to the latest tip master branch, >> but failed. > >The patch is based on Linus's v5.1-rc2. Thanks, Chao Fan > >-- >Jun'ichi Nomura, NEC Corporation / NEC Solution Innovators, Ltd. > > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec