From: Kairui Song <kasong@redhat.com>
To: kexec@lists.infradead.org
Cc: Simon Horman <horms@verge.net.au>, Dave Young <dyoung@redhat.com>,
Lianbo Jiang <lijiang@redhat.com>, Baoquan He <bhe@redhat.com>,
Kairui Song <kasong@redhat.com>
Subject: [PATCH v2 3/4] x86: Always try to fill acpi_rsdp_addr in boot params
Date: Tue, 14 May 2019 13:09:59 +0800 [thread overview]
Message-ID: <20190514050959.21093-4-kasong@redhat.com> (raw)
In-Reply-To: <20190514050959.21093-1-kasong@redhat.com>
Since kernel commit e6e094e053af75 ("x86/acpi, x86/boot: Take RSDP address
from boot params if available"), kernel accept an acpi_rsdp_addr param in
boot_params. So fill in this parameter unconditionally, ensure second
kernel always get the right RSDP address consistently, and boot well on
EFI system even with EFI service disabled. User no longer need to change
the kernel cmdline to workaround the missing RSDP issue.
For older version of kernels (Before 5.0), there won't be any change of
behavior.
Signed-off-by: Kairui Song <kasong@redhat.com>
---
kexec/arch/i386/x86-linux-setup.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/kexec/arch/i386/x86-linux-setup.c b/kexec/arch/i386/x86-linux-setup.c
index 5ca7c25..5b00b42 100644
--- a/kexec/arch/i386/x86-linux-setup.c
+++ b/kexec/arch/i386/x86-linux-setup.c
@@ -901,4 +901,7 @@ void setup_linux_system_parameters(struct kexec_info *info,
/* fill the EDD information */
setup_edd_info(real_mode);
+
+ /* Always try to fill acpi_rsdp_addr */
+ real_mode->acpi_rsdp_addr = get_acpi_rsdp();
}
--
2.20.1
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-05-14 5:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-05-14 5:09 [PATCH v2 0/4] x86: Always to to fill acpi_rsdp_addr in boot params Kairui Song
2019-05-14 5:09 ` [PATCH v2 1/4] x86: Update boot parameters defination Kairui Song
2019-05-23 3:01 ` Dave Young
2019-05-23 11:12 ` Kairui Song
2019-05-23 13:26 ` Dave Young
2019-05-14 5:09 ` [PATCH v2 2/4] x86: Introduce helpers for getting RSDP address Kairui Song
2019-05-23 3:16 ` Dave Young
2019-05-23 3:43 ` Kairui Song
2019-05-23 11:06 ` Kairui Song
2019-05-14 5:09 ` Kairui Song [this message]
2019-05-23 3:17 ` [PATCH v2 3/4] x86: Always try to fill acpi_rsdp_addr in boot params Dave Young
2019-05-14 5:15 ` [PATCH v2 4/4] crashdump/x86: Use new introduced helper for getting RSDP Kairui Song
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514050959.21093-4-kasong@redhat.com \
--to=kasong@redhat.com \
--cc=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=lijiang@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox