From: Dave Young <dyoung@redhat.com>
To: Baoquan He <bhe@redhat.com>
Cc: fanc.fnst@cn.fujitsu.com, kasong@redhat.com, x86@kernel.org,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org,
Borislav Petkov <bp@alien8.de>,
hpa@zytor.com, j-nomura@ce.jp.nec.com, tglx@linutronix.de
Subject: Re: [PATCH v6 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables
Date: Tue, 14 May 2019 16:48:41 +0800 [thread overview]
Message-ID: <20190514084841.GA27876@dhcp-128-65.nay.redhat.com> (raw)
In-Reply-To: <20190514032208.GA25875@dhcp-128-65.nay.redhat.com>
On 05/14/19 at 11:22am, Dave Young wrote:
> On 05/13/19 at 04:06pm, Baoquan He wrote:
> > Hi Dave,
> >
> > On 05/13/19 at 09:50am, Borislav Petkov wrote:
> > > On Mon, May 13, 2019 at 03:32:54PM +0800, Baoquan He wrote:
> > > > This is a critical bug which breaks memory hotplug,
> > >
> > > Please concentrate and stop the blabla:
> > >
> > > 36f0c423552d ("x86/boot: Disable RSDP parsing temporarily")
> > >
> > > already explains what the deal is. This code was *purposefully* disabled
> > > because we ran out of time and it broke a couple of machines. Don't make
> >
> > I remember your machine is the one on whihc the issue is reported. Could
> > you also test it and confirm if these all things found ealier are
> > cleared out?
> >
>
> I did some tests on the laptop, thing is:
> 1. apply the 3 patches (two you posted + Boris's revert commit 52b922c3d49c)
> on latest Linus master branch, everything works fine.
>
> 2. build and test the tip/next-merge-window branch, kernel hangs early
> without output, (both 1st boot and kexec boot)
Update about 2. It should be not early rsdp related, I got the boot log
Since can not reproduce with Linus master branch it may have been fixed.
[ 0.685374][ T1] rcu: Hierarchical SRCU implementation.
[ 0.686414][ T1] general protection fault: 0000 [#1] SMP PTI
[ 0.687328][ T1] CPU: 0 PID: 1 Comm: swapper/0 Not tainted 5.1.0-rc6+ #877
[ 0.687328][ T1] Hardware name: LENOVO 4236NUC/4236NUC, BIOS 83ET82WW (1.52 ) 06/04/2018
[ 0.687328][ T1] RIP: 0010:reserve_ds_buffers+0x34e/0x450
[ 0.687328][ T1] Code: e8 77 49 1a 00 4c 8b 54 24 18 48 85 c0 4c 8b 4c 24 10 48 89 44 24 20 0f 84 68 fe ff ff 4a 8b 0c cd 20 88 07 a7 48 8d 54 24 20 <48> 89 04 11 e9 e5 fd ff ff 85 db 0f 85 67 fe ff ff 45 85 ed 75 24
[ 0.687328][ T1] RSP: 0000:ffffa52100c8bd90 EFLAGS: 00010286
[ 0.687328][ T1] RAX: ffff8c6bd5d03000 RBX: 0000000000000000 RCX: ffff8c6bd6000000
[ 0.687328][ T1] RDX: ffffa52100c8bdb0 RSI: ffffffffa620e209 RDI: ffff8c6bd5d04000
[ 0.687328][ T1] RBP: ffff8c6bd60103a0 R08: ffff8c6bd4da0000 R09: 0000000000000000
[ 0.687328][ T1] R10: ffff8c6bd4e20000 R11: ffffc8e248538800 R12: 00000000000103a0
[ 0.687328][ T1] R13: 0000000000010000 R14: fffffe0000013000 R15: 0000000000000000
[ 0.687328][ T1] FS: 0000000000000000(0000) GS:ffff8c6bd6000000(0000) knlGS:0000000000000000
[ 0.687328][ T1] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 0.687328][ T1] CR2: ffff8c6bde5ff000 CR3: 000000015700e001 CR4: 00000000000606f0
[ 0.687328][ T1] Call Trace:
[ 0.687328][ T1] ? hardlockup_detector_event_create+0x50/0x50
[ 0.687328][ T1] x86_reserve_hardware+0x173/0x180
[ 0.687328][ T1] x86_pmu_event_init+0x39/0x220
[ 0.687328][ T1] ? hardlockup_detector_event_create+0x50/0x50
[ 0.687328][ T1] perf_try_init_event+0x42/0xd0
[ 0.687328][ T1] perf_event_alloc+0x46a/0x8b0
[ 0.687328][ T1] perf_event_create_kernel_counter+0x21/0x130
[ 0.687328][ T1] hardlockup_detector_event_create+0x39/0x50
[ 0.687328][ T1] hardlockup_detector_perf_init+0xc/0x40
[ 0.687328][ T1] lockup_detector_init+0x3a/0x71
[ 0.687328][ T1] kernel_init_freeable+0xbc/0x231
[ 0.687328][ T1] ? rest_init+0x9f/0x9f
[ 0.687328][ T1] kernel_init+0xa/0x101
[ 0.687328][ T1] ret_from_fork+0x35/0x40
[ 0.687328][ T1] Modules linked in:
[ 0.687331][ T1] ---[ end trace 71ee47f6125e74a4 ]---
[ 0.688331][ T1] RIP: 0010:reserve_ds_buffers+0x34e/0x450
[ 0.689330][ T1] Code: e8 77 49 1a 00 4c 8b 54 24 18 48 85 c0 4c 8b 4c 24 10 48 89 44 24 20 0f 84 68 fe ff ff 4a 8b 0c cd 20 88 07 a7 48 8d 54 24 20 <48> 89 04 11 e9 e5 fd ff ff 85 db 0f 85 67 fe ff ff 45 85 ed 75 24
[ 0.690330][ T1] RSP: 0000:ffffa52100c8bd90 EFLAGS: 00010286
[ 0.691330][ T1] RAX: ffff8c6bd5d03000 RBX: 0000000000000000 RCX: ffff8c6bd6000000
[ 0.692330][ T1] RDX: ffffa52100c8bdb0 RSI: ffffffffa620e209 RDI: ffff8c6bd5d04000
[ 0.693330][ T1] RBP: ffff8c6bd60103a0 R08: ffff8c6bd4da0000 R09: 0000000000000000
[ 0.694330][ T1] R10: ffff8c6bd4e20000 R11: ffffc8e248538800 R12: 00000000000103a0
[ 0.695330][ T1] R13: 0000000000010000 R14: fffffe0000013000 R15: 0000000000000000
[ 0.696330][ T1] FS: 0000000000000000(0000) GS:ffff8c6bd6000000(0000) knlGS:0000000000000000
[ 0.697330][ T1] CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033
[ 0.698330][ T1] CR2: ffff8c6bde5ff000 CR3: 000000015700e001 CR4: 00000000000606f0
[ 0.699334][ T1] Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b
[ 0.700328][ T1] ---[ end Kernel panic - not syncing: Attempted to kill init! exitcode=0x0000000b ]---
Thanks
Dave
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-05-14 8:48 UTC|newest]
Thread overview: 41+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-24 9:29 [PATCH v5 0/2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Baoquan He
2019-04-24 9:29 ` [PATCH v5 1/2] x86/kexec: Build identity mapping for EFI systab and ACPI tables Baoquan He
2019-04-27 16:11 ` Borislav Petkov
2019-04-28 5:41 ` Baoquan He
2019-04-29 12:50 ` Borislav Petkov
2019-04-29 0:23 ` [PATCH v6 " Baoquan He
2019-04-29 13:55 ` Borislav Petkov
2019-04-29 14:16 ` Baoquan He
2019-05-13 1:43 ` Baoquan He
2019-05-13 7:07 ` Borislav Petkov
2019-05-13 7:32 ` Baoquan He
2019-05-13 7:50 ` Borislav Petkov
2019-05-13 8:02 ` Baoquan He
2019-05-15 5:17 ` Junichi Nomura
2019-05-15 6:58 ` Borislav Petkov
2019-05-15 7:09 ` Junichi Nomura
2019-05-21 9:02 ` Kairui Song
2019-05-21 10:43 ` Junichi Nomura
2019-05-21 18:09 ` Borislav Petkov
2019-05-28 2:49 ` Kairui Song
2019-06-06 19:20 ` Borislav Petkov
2019-05-13 8:06 ` Baoquan He
2019-05-14 3:22 ` Dave Young
2019-05-14 3:33 ` Baoquan He
2019-05-21 21:53 ` Dirk van der Merwe
2019-05-21 23:04 ` Borislav Petkov
2019-05-14 8:48 ` Dave Young [this message]
2019-05-14 11:18 ` Kairui Song
2019-05-14 11:38 ` Peter Zijlstra
2019-05-14 12:58 ` Dave Young
2019-05-14 13:54 ` Peter Zijlstra
2019-05-14 14:09 ` Ingo Molnar
2019-05-15 1:08 ` Dave Young
2019-05-15 6:43 ` Junichi Nomura
2019-05-17 13:41 ` Borislav Petkov
2019-05-17 13:50 ` [PATCH] x86/boot: Call get_rsdp_addr() after console_init() Borislav Petkov
2019-05-21 9:28 ` Baoquan He
2019-04-24 9:29 ` [PATCH v5 2/2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernels Baoquan He
2019-04-24 9:33 ` Baoquan He
2019-04-24 9:38 ` [PATCH v5 0/2] x86/boot: Use efi_setup_data for searching RSDP on kexec-ed kernel Borislav Petkov
2019-04-24 10:00 ` Baoquan He
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190514084841.GA27876@dhcp-128-65.nay.redhat.com \
--to=dyoung@redhat.com \
--cc=bhe@redhat.com \
--cc=bp@alien8.de \
--cc=fanc.fnst@cn.fujitsu.com \
--cc=hpa@zytor.com \
--cc=j-nomura@ce.jp.nec.com \
--cc=kasong@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox