From: Borislav Petkov <bp@alien8.de>
To: lijiang <lijiang@redhat.com>
Cc: jgross@suse.com, Thomas.Lendacky@amd.com, bhe@redhat.com,
horms@verge.net.au, x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, dhowells@redhat.com,
mingo@redhat.com, ebiederm@xmission.com, hpa@zytor.com,
tglx@linutronix.de, dyoung@redhat.com, d.hatayama@fujitsu.com,
vgoyal@redhat.com
Subject: Re: [PATCH 1/2 RESEND v8] x86/kdump: always reserve the low 1M when the crashkernel option is specified
Date: Thu, 31 Oct 2019 11:47:48 +0100 [thread overview]
Message-ID: <20191031104748.GC21133@nazgul.tnic> (raw)
In-Reply-To: <fe68b796-c483-20c4-623c-2671c52a3bf9@redhat.com>
On Thu, Oct 31, 2019 at 05:40:35PM +0800, lijiang wrote:
> Maybe it should be a separate patch to fix the old compile warnings as follow.
> And i should put the patch into this series.
Yes, maybe.
> commit d2091d1f4f67f1c38293b0e93fdbfefa766940cf (HEAD -> master)
> Author: Lianbo Jiang <lijiang@redhat.com>
> Date: Thu Oct 31 15:48:02 2019 +0800
>
> kexec: Fix i386 build warnings that missed declaration of struct kimage
>
> Kbuild test robot reported some build warnings, please refer to the
> Link below for details.
Explain here what the warnings are, why they trigger and how you're
fixing it. How a commit message should look like is also explained in
that document I pointed you at.
Refering to some link is not what we do in commit messages.
> Add a declaration of struct kimage to fix these compile warnings.
>
> Fixes: dd5f726076cc ("kexec: support for kexec on panic using new system call")
> Reported-by: kbuild test robot <lkp@intel.com>
> Signed-off-by: Lianbo Jiang <lijiang@redhat.com>
> Link: https://lkml.org/lkml/2019/10/30/833
*NEVER* use lkml.org or any other external URL for refering to mail
threads but *always* use our own
lkml.kernel.org/r/<Message-ID>
redirector. See other tip commits for an example.
> > You can read
> >
> > https://www.kernel.org/doc/html/latest/process/submitting-patches.html
> >
> > in the meantime, especially section
> >
> > "9) Don't get discouraged - or impatient"
> >
> > while waiting.
>
> OK. Thanks.
And make sure to read that whole document and also have a look at the
process document
https://www.kernel.org/doc/html/latest/process/index.html
so that you can avoid such mistakes in the future.
Thx.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
--
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2019-10-31 10:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-31 3:35 [PATCH 0/2 RESEND v8] x86/kdump: Fix 'kmem -s' reported an invalid freepointer when SME was active Lianbo Jiang
2019-10-31 3:35 ` [PATCH 1/2 RESEND v8] x86/kdump: always reserve the low 1M when the crashkernel option is specified Lianbo Jiang
2019-10-31 7:13 ` Borislav Petkov
2019-10-31 9:40 ` lijiang
2019-10-31 10:47 ` Borislav Petkov [this message]
2019-11-01 7:12 ` lijiang
2019-10-31 3:35 ` [PATCH 2/2 RESEND v8] x86/kdump: clean up all the code related to the backup region Lianbo Jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20191031104748.GC21133@nazgul.tnic \
--to=bp@alien8.de \
--cc=Thomas.Lendacky@amd.com \
--cc=bhe@redhat.com \
--cc=d.hatayama@fujitsu.com \
--cc=dhowells@redhat.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=hpa@zytor.com \
--cc=jgross@suse.com \
--cc=kexec@lists.infradead.org \
--cc=lijiang@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=vgoyal@redhat.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox