From: Simon Horman <horms@verge.net.au>
To: Lukasz Stelmach <l.stelmach@samsung.com>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH v2] arm: redefine OPT_APPEND and OPT_RAMDISK
Date: Wed, 22 Apr 2020 10:01:57 +0200 [thread overview]
Message-ID: <20200422080151.GA32200@vergenet.net> (raw)
In-Reply-To: <dleftjmu76ns60.fsf%l.stelmach@samsung.com>
On Mon, Apr 20, 2020 at 04:33:11PM +0200, Lukasz Stelmach wrote:
> > On Wed, Apr 15, 2020 at 12:58:45PM +0200, Łukasz Stelmach wrote:
> >> Redefine OPT_APPEND to avoid clash with OPT_KEXEC_SYSCALL_AUTO.
> >> Redefine OPT_RAMDISK to avoid such problems in the future
> >>
> >> Signed-off-by: Łukasz Stelmach <l.stelmach at samsung.com>
> >
> > I am slightly concerned that this will break things for users.
> > But OTOH perhaps we already broke things when adding
> > OPT_KEXEC_SYSCALL_AUTO.
> > Do you have any thoughts on this?
>
> I am aware of this, but the current appears to be broken more. When I
> was using '-a' it didn't work as advertised in the usage message. Short
> *arch* options aren't documented there, so I suppose most people didn't
> use them. ARM is the only architecture that supports short options by
> defining OPT_* as characters. HPPA appears to be using them in the
> optstring (copied from ARM?) but not in OPT_*. Would you like me to
> clean this up too in v3?
>
> In summary: undocumented, on one platform.
>
> P.S. Please, cc me. I am not subscribed to the list.
Thanks Łukasz,
I take your point with regards to these features being undocumented.
And I think the extra clean-up you suggest sounds good.
Could you post a v3 with that included?
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2020-04-22 8:02 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200414085411eucas1p240d872905d55681ab4a3d9bb9f584563@eucas1p2.samsung.com>
2020-04-14 8:52 ` [PATCH] arm: redefine OPT_APPEND and OPT_RAMDISK Łukasz Stelmach
2020-04-15 10:58 ` [PATCH v2] " Łukasz Stelmach
2020-04-16 8:44 ` Simon Horman
2020-04-20 14:33 ` Lukasz Stelmach
2020-04-22 8:01 ` Simon Horman [this message]
2020-04-22 19:45 ` [PATCH v3] " Łukasz Stelmach
2020-04-24 9:40 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200422080151.GA32200@vergenet.net \
--to=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=l.stelmach@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox