From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pg1-x543.google.com ([2607:f8b0:4864:20::543]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jygix-0004sS-NO for kexec@lists.infradead.org; Thu, 23 Jul 2020 19:17:48 +0000 Received: by mail-pg1-x543.google.com with SMTP id l63so3629903pge.12 for ; Thu, 23 Jul 2020 12:17:47 -0700 (PDT) Date: Thu, 23 Jul 2020 12:17:43 -0700 From: Kees Cook Subject: Re: [PATCH v2 15/18] fs/kernel_file_read: Add "offset" arg for partial reads Message-ID: <202007231215.D6E097C@keescook> References: <20200722193020.2676422-1-keescook@chromium.org> <20200722193020.2676422-16-keescook@chromium.org> <354ec0c3-b56d-f5b5-574f-4032fee0b55a@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <354ec0c3-b56d-f5b5-574f-4032fee0b55a@broadcom.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Scott Branden Cc: linux-efi@vger.kernel.org, "Rafael J. Wysocki" , Peter Zijlstra , linux-fsdevel@vger.kernel.org, Stephen Boyd , SeongJae Park , Mimi Zohar , David Howells , Tushar Sugandhi , Peter Jones , linux-kselftest@vger.kernel.org, "Joel Fernandes (Google)" , Shuah Khan , Ard Biesheuvel , Thomas Cedeno , linux-security-module@vger.kernel.org, Anders Roxell , Paul Moore , Mauro Carvalho Chehab , Michael Ellerman , Nayna Jain , Matthew Garrett , James Morris , Lakshmi Ramasubramanian , Aaron Goidel , "Serge E. Hallyn" , Wenwen Wang , selinux@vger.kernel.org, Jessica Yu , Hans de Goede , Alexander Viro , Matthieu Baerts , KP Singh , Eric Paris , linux-integrity@vger.kernel.org, Florent Revest , Andrea Righi , Greg Kroah-Hartman , Stephen Smalley , Randy Dunlap , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Eric Biederman , Dave Olsthoorn , Dmitry Kasatkin , Casey Schaufler , Joe Perches , Andrew Morton , Thiago Jung Bauermann On Wed, Jul 22, 2020 at 11:23:43PM -0700, Scott Branden wrote: > I made an adjustment in the logic of the driver with use of > request_partial_firmware_into_buf and now everything is working. Excellent! Was there something wrong with how I ported the request_partial_firmware_into_buf() changes? (Should the behavior be changed in some way? I didn't change the self-tests, so I thought the behavior matched your original series.) > So only issue I find with this entire patch series is the problem > of security failing without the workaround below. Yup; I'm trying to reproduce this now too... -- Kees Cook _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec