From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail-pf1-x444.google.com ([2607:f8b0:4864:20::444]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1jz3Kz-0002iL-6A for kexec@lists.infradead.org; Fri, 24 Jul 2020 19:26:35 +0000 Received: by mail-pf1-x444.google.com with SMTP id u185so5776266pfu.1 for ; Fri, 24 Jul 2020 12:26:32 -0700 (PDT) Date: Fri, 24 Jul 2020 12:26:28 -0700 From: Kees Cook Subject: Re: [PATCH v2 15/18] fs/kernel_file_read: Add "offset" arg for partial reads Message-ID: <202007241207.0B09E32@keescook> References: <20200722193020.2676422-1-keescook@chromium.org> <20200722193020.2676422-16-keescook@chromium.org> <202007231131.9704A8B330@keescook> <02cffea0-5ed4-05a5-f86d-b6643f32e595@broadcom.com> <202007241122.50FD503@keescook> <202007241138.8A3E468@keescook> <02221f39-ad01-c45d-cc60-a3ffe3d0d284@broadcom.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <02221f39-ad01-c45d-cc60-a3ffe3d0d284@broadcom.com> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Scott Branden , Mimi Zohar Cc: linux-efi@vger.kernel.org, "Rafael J. Wysocki" , Peter Zijlstra , linux-fsdevel@vger.kernel.org, Stephen Boyd , SeongJae Park , Aaron Goidel , David Howells , Tushar Sugandhi , Peter Jones , linux-kselftest@vger.kernel.org, "Joel Fernandes (Google)" , Shuah Khan , Ard Biesheuvel , Thomas Cedeno , linux-security-module@vger.kernel.org, Anders Roxell , Paul Moore , Mauro Carvalho Chehab , Michael Ellerman , Nayna Jain , Matthew Garrett , James Morris , Lakshmi Ramasubramanian , "Serge E. Hallyn" , Wenwen Wang , selinux@vger.kernel.org, Jessica Yu , Hans de Goede , Alexander Viro , Matthieu Baerts , KP Singh , Eric Paris , linux-integrity@vger.kernel.org, Florent Revest , Andrea Righi , Greg Kroah-Hartman , Stephen Smalley , Randy Dunlap , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Luis Chamberlain , Eric Biederman , Dave Olsthoorn , Dmitry Kasatkin , Casey Schaufler , Joe Perches , Andrew Morton , Thiago Jung Bauermann On Fri, Jul 24, 2020 at 12:03:36PM -0700, Scott Branden wrote: > Now I'm confused.=A0 The original patch series I made with IMA additions = under > Mimi's direction > passed the kernel selftests with partial read.=A0 And > request_partial_firmware_into_buf therefore worked. > Your changes don't work with CONFIG_IMA_APPRAISE=3Dy on?=A0 Is there a wa= y to > make IMA ignore this file to make things work then? > Seems like another change is needed for IMA to ignore partial reads if it > can't appraise them? Ah yes, I missed this in porting your series[1] (i.e. calling process_measurement() with a valid "file" and NULL "buf" is handled correctly -- I misunderstood these changes). I will send a corrected patch. -Kees [1] https://lore.kernel.org/lkml/20200706232309.12010-10-scott.branden@broa= dcom.com/ -- = Kees Cook _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec