Re: [PATCH v2 15/18] fs/kernel_file_read: Add "offset" arg for partial reads

Kees Cook
2020-07-24T19:26:35Z

On Fri, Jul 24, 2020 at 12:03:36PM -0700, Scott Branden wrote:
> Now I'm confused.  The original patch series I made with IMA additions under
> Mimi's direction
> passed the kernel selftests with partial read.  And
> request_partial_firmware_into_buf therefore worked.
> Your changes don't work with CONFIG_IMA_APPRAISE=y on?  Is there a way to
> make IMA ignore this file to make things work then?
> Seems like another change is needed for IMA to ignore partial reads if it
> can't appraise them?

Ah yes, I missed this in porting your series[1] (i.e. calling
process_measurement() with a valid "file" and NULL "buf" is handled
correctly -- I misunderstood these changes). I will send a corrected
patch.

-Kees

[1] https://lore.kernel.org/lkml/20200706232309.12010-10-scott.branden@broadcom.com/

--
Kees Cook