From: Kees Cook <keescook@chromium.org>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: kernel-hardening@lists.openwall.com,
Peter Zijlstra <peterz@infradead.org>,
David Howells <dhowells@redhat.com>,
linux-mm@kvack.org, Alexander Potapenko <glider@google.com>,
kasan-dev@googlegroups.com, Christoph Lameter <cl@linux.com>,
Will Deacon <will@kernel.org>, Pekka Enberg <penberg@kernel.org>,
Masahiro Yamada <masahiroy@kernel.org>,
Krzysztof Kozlowski <krzk@kernel.org>,
David Rientjes <rientjes@google.com>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Laura Abbott <labbott@redhat.com>,
Alexander Popov <alex.popov@linux.com>,
Arnd Bergmann <arnd@arndb.de>, Jann Horn <jannh@google.com>,
Steven Rostedt <rostedt@goodmis.org>,
Joonsoo Kim <iamjoonsoo.kim@lge.com>,
Dmitry Vyukov <dvyukov@google.com>,
notify@kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Kexec Mailing List <kexec@lists.infradead.org>,
linux-kernel@vger.kernel.org,
Patrick Bellasi <patrick.bellasi@arm.com>,
Masami Hiramatsu <mhiramat@kernel.org>,
Johannes Weiner <hannes@cmpxchg.org>,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: [PATCH RFC 2/2] lkdtm: Add heap spraying test
Date: Mon, 17 Aug 2020 12:24:29 -0700 [thread overview]
Message-ID: <202008171222.3F206231E@keescook> (raw)
In-Reply-To: <87zh6t9llm.fsf@x220.int.ebiederm.org>
On Mon, Aug 17, 2020 at 01:24:37PM -0500, Eric W. Biederman wrote:
> Alexander Popov <alex.popov@linux.com> writes:
>
> > Add a simple test for CONFIG_SLAB_QUARANTINE.
> >
> > It performs heap spraying that aims to reallocate the recently freed heap
> > object. This technique is used for exploiting use-after-free
> > vulnerabilities in the kernel code.
> >
> > This test shows that CONFIG_SLAB_QUARANTINE breaks heap spraying
> > exploitation technique.
> >
> > Signed-off-by: Alexander Popov <alex.popov@linux.com>
>
> Why put this test in the linux kernel dump test module?
>
> I have no problem with tests, and I may be wrong but this
> does not look like you are testing to see if heap corruption
> triggers a crash dump. Which is what the rest of the tests
> in lkdtm are about. Seeing if the test triggers successfully
> triggers a crash dump.
The scope of LKDTM has shifted a bit, and I'm fine with tests that
don't cause crashes as long as they're part of testing system-wide
defenses, etc. It's easier to collect similar tests together (even if
they don't break the system).
--
Kees Cook
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2020-08-17 19:24 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20200813151922.1093791-1-alex.popov@linux.com>
[not found] ` <20200813151922.1093791-3-alex.popov@linux.com>
2020-08-17 18:24 ` [PATCH RFC 2/2] lkdtm: Add heap spraying test Eric W. Biederman
2020-08-17 19:24 ` Kees Cook [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202008171222.3F206231E@keescook \
--to=keescook@chromium.org \
--cc=akpm@linux-foundation.org \
--cc=alex.popov@linux.com \
--cc=arnd@arndb.de \
--cc=aryabinin@virtuozzo.com \
--cc=cl@linux.com \
--cc=dhowells@redhat.com \
--cc=dvyukov@google.com \
--cc=ebiederm@xmission.com \
--cc=glider@google.com \
--cc=gregkh@linuxfoundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=jannh@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=kernel-hardening@lists.openwall.com \
--cc=kexec@lists.infradead.org \
--cc=krzk@kernel.org \
--cc=labbott@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=masahiroy@kernel.org \
--cc=mhiramat@kernel.org \
--cc=notify@kernel.org \
--cc=patrick.bellasi@arm.com \
--cc=penberg@kernel.org \
--cc=peterz@infradead.org \
--cc=rientjes@google.com \
--cc=rostedt@goodmis.org \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox