Re: [PATCH v11 2/5] x86: kdump: move reserve_crashkernel_low() into crash_core.c

Catalin Marinas
2020-09-01T16:50:02Z

On Thu, Aug 06, 2020 at 03:36:27PM +0200, Ingo Molnar wrote:
>
> * Chen Zhou <chenzhou10@huawei.com> wrote:
>
> > In preparation for supporting reserve_crashkernel_low in arm64 as
> > x86_64 does, move reserve_crashkernel_low() into kernel/crash_core.c.
> >
> > BTW, move x86_64 CRASH_ALIGN to 2M suggested by Dave. CONFIG_PHYSICAL_ALIGN
> > can be selected from 2M to 16M, move to the same as arm64.
> >
> > Signed-off-by: Chen Zhou <chenzhou10@huawei.com>
> > ---
> > arch/x86/include/asm/kexec.h | 24 ++++++++++
> > arch/x86/kernel/setup.c | 86 +++---------------------------------
> > include/linux/crash_core.h | 3 ++
> > include/linux/kexec.h | 2 -
> > kernel/crash_core.c | 74 +++++++++++++++++++++++++++++++
> > kernel/kexec_core.c | 17 -------
> > 6 files changed, 107 insertions(+), 99 deletions(-)
>
> Since the changes are centered around arm64, I suppose the arm64 tree
> will carry this patchset?
>
> Assuming that this is a 100% invariant moving of code that doesn't
> regress on x86:
>
> Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks Ingo. The only difference I see is that CRASH_ALIGN has been
reduced to 2M here from 16M for x86. Would this break configs that have
PHYSICAL_ALIGN > 2M?

--
Catalin