From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx2.suse.de ([195.135.220.15]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kKMIt-00061z-M0 for kexec@lists.infradead.org; Mon, 21 Sep 2020 13:56:28 +0000 Date: Mon, 21 Sep 2020 15:56:25 +0200 From: Petr Mladek Subject: Re: [PATCH printk v4 2/3] printk: move dictionary keys to dev_printk_info Message-ID: <20200921135625.GC31052@alley> References: <20200918223421.21621-1-john.ogness@linutronix.de> <20200918223421.21621-3-john.ogness@linutronix.de> <20200921095557.GH14605@alley> <87r1qvl6yc.fsf@jogness.linutronix.de> <87mu1jl6ne.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <87mu1jl6ne.fsf@jogness.linutronix.de> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: John Ogness Cc: Sergey Senozhatsky , Greg Kroah-Hartman , kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Steven Rostedt , Sergey Senozhatsky , Thomas Gleixner , Linus Torvalds On Mon 2020-09-21 13:24:45, John Ogness wrote: > Dictionaries are only used for SUBSYSTEM and DEVICE properties. The > current implementation stores the property names each time they are > used. This requires more space than otherwise necessary. Also, > because the dictionary entries are currently considered optional, > it cannot be relied upon that they are always available, even if the > writer wanted to store them. These issues will increase should new > dictionary properties be introduced. > > Rather than storing the subsystem and device properties in the > dict ring, introduce a struct dev_printk_info with separate fields > to store only the property values. Embed this struct within the > struct printk_info to provide guaranteed availability. > > Signed-off-by: John Ogness > Reviewed-by: Petr Mladek > --- > Sorry. v3 did not include Petr's fixup correctly. @size was wrong. > Now it is correct. I could confirm that the added line and the patch looks fine now. Best Regards, Petr _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec