Re: [PATCH 1/1] kdump: append uts_namespace.name offset to VMCOREINFO

["dyoung@redhat.com" <dyoung@redhat.com>]

Hi Kazu,
On 09/23/20 at 04:37am, HAGIO KAZUHITO(萩尾 一仁) wrote:
> Hi Dave,
> 
> sorry to bother you.  We need this kernel patch to fix a makedumpfile issue
> with the current linux-next.  Should we send this to the addresses below, right?
> I'm not sure whether they are enough.

It is good, but I suggest also cc Eric:
"Eric W. Biederman" <ebiederm@xmission.com>

BTW, the -next commit log should mention which branch the commit stays, and it
would be better to add the original discussion link eg. the patch link on
lore.kernel.org
 
> 
> Alex,
> 
> Thanks for the patch.  Since this patch is for kernel, it needs to be sent
> to kernel maintainers and mailing lists, and I think you can get their
> addresses with scripts/get_maintainer.pl in the kernel tree.
> 
> $ scripts/get_maintainer.pl /tmp/a.patch 
> Dave Young <dyoung@redhat.com> (maintainer:KDUMP)
> Baoquan He <bhe@redhat.com> (maintainer:KDUMP)
> Vivek Goyal <vgoyal@redhat.com> (reviewer:KDUMP)
> kexec@lists.infradead.org (open list:KDUMP)
> linux-kernel@vger.kernel.org (open list)
> 
> Thanks,
> Kazu
> 
> -----Original Message-----
> > The offset of the field 'init_uts_ns.name' has changed
> > since commit 9a56493f6942c0e2df1579986128721da96e00d8.
> > Make the offset of the field 'uts_namespace.name' available
> > in VMCOREINFO because tools like 'crash-utility' and
> > 'makedumpfile' must be able to read it from crash dumps.
> > 
> > Signed-off-by: Alexander Egorenkov <egorenar@linux.ibm.com>
> > ---
> >  kernel/crash_core.c | 1 +
> >  1 file changed, 1 insertion(+)
> > 
> > diff --git a/kernel/crash_core.c b/kernel/crash_core.c
> > index 106e4500fd53..173fdc261882 100644
> > --- a/kernel/crash_core.c
> > +++ b/kernel/crash_core.c
> > @@ -447,6 +447,7 @@ static int __init crash_save_vmcoreinfo_init(void)
> >  	VMCOREINFO_PAGESIZE(PAGE_SIZE);
> > 
> >  	VMCOREINFO_SYMBOL(init_uts_ns);
> > +	VMCOREINFO_OFFSET(uts_namespace, name);
> >  	VMCOREINFO_SYMBOL(node_online_map);
> >  #ifdef CONFIG_MMU
> >  	VMCOREINFO_SYMBOL_ARRAY(swapper_pg_dir);
> > --
> > 2.26.2
> > 
> > 
> > _______________________________________________
> > kexec mailing list
> > kexec@lists.infradead.org
> > http://lists.infradead.org/mailman/listinfo/kexec
> 
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
> 

Thanks
Dave


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec