From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mail.kernel.org ([198.145.29.99]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1kjpeq-0006YQ-Cn for kexec@lists.infradead.org; Mon, 30 Nov 2020 20:20:26 +0000 Date: Mon, 30 Nov 2020 14:20:21 -0600 From: Bjorn Helgaas Subject: Re: [PATCH 1/3] x86/quirks: Scan all busses for early PCI quirks Message-ID: <20201130202021.GA1106292@bjorn-Precision-5520> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Guilherme Piccoli Cc: Guowen Shan , linux-pci@vger.kernel.org, Pingfan Liu , andi@firstfloor.org, "H. Peter Anvin" , Baoquan He , x86@kernel.org, Sinan Kaya , Ingo Molnar , Jay Vosburgh , Dave Young , Gavin Guo , Borislav Petkov , Bjorn Helgaas , Thomas Gleixner , kexec mailing list , "Guilherme G. Piccoli" , "Rafael J. Wysocki" , LKML , Vivek Goyal , Dan Streetman , lukas@wunner.de, "Eric W. Biederman" On Wed, Nov 18, 2020 at 07:36:08PM -0300, Guilherme Piccoli wrote: > Thanks a lot Bjorn! I confess except for PPC64 Server machines, I > never saw other "domains" or segments. Is it common in x86 to have > that? The early_quirks() are restricted to the first segment, no > matter how many host bridges we have in segment 0000? I don't know whether it's *common* to have multiple domains on x86, but they're definitely used on large systems. This includes some lspci info from an HPE Superdome Flex system: https://lore.kernel.org/lkml/5350E02A-6457-41A8-8F33-AF67BFDAEE3E@fb.com/ The early quirks in arch/x86/kernel/early-quirks.c (not the DECLARE_PCI_FIXUP_EARLY quirks in drivers/pci/quirks.c) are restricted to segment 0, no matter how many host bridges there are. This is because they use read_pci_config_16(), which uses a config access mechanism that has no provision for a segment number. Bjorn _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec