From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from us-smtp-delivery-124.mimecast.com ([63.128.21.124]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1lEYAp-0001O5-0M for kexec@lists.infradead.org; Tue, 23 Feb 2021 13:56:25 +0000 Date: Tue, 23 Feb 2021 21:56:05 +0800 From: Baoquan He Subject: Re: [PATCH v3 1/1] kernel/crash_core: Add crashkernel=auto for vmcore creation Message-ID: <20210223135605.GA3553@MiWiFi-R3L-srv> References: <20210211180814.69708-1-saeed.mirzamohammadi@oracle.com> <20210218020203.GC2871@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Saeed Mirzamohammadi , Kairui Song Cc: linux-doc@vger.kernel.org, "Peter Zijlstra (Intel)" , Christian Brauner , Ingo Molnar , Jonathan Corbet , Mauro Carvalho Chehab , Masahiro Yamada , Sami Tolvanen , Dave Young , Vivek Goyal , John Donnelly , Kees Cook , "Paul E. McKenney" , Andrey Konovalov , Frederic Weisbecker , "Guilherme G. Piccoli" , "Steven Rostedt (VMware)" , Josh Poimboeuf , Thomas Gleixner , Stephen Boyd , Randy Dunlap , kexec@lists.infradead.org, Linux Kernel Mailing List , YiFei Zhu , Andrew Morton , Mike Rapoport , Mike Kravetz On 02/23/21 at 08:01pm, Kairui Song wrote: > On Thu, Feb 18, 2021 at 10:03 AM Baoquan He wrote: > > > > On 02/11/21 at 10:08am, Saeed Mirzamohammadi wrote: ... > > > diff --git a/arch/Kconfig b/arch/Kconfig > > > index af14a567b493..f87c88ffa2f8 100644 > > > --- a/arch/Kconfig > > > +++ b/arch/Kconfig > > > @@ -14,6 +14,30 @@ menu "General architecture-dependent options" > > > config CRASH_CORE > > > bool > > > > > > +if CRASH_CORE > > > + > > > +config CRASH_AUTO_STR > > > + string "Memory reserved for crash kernel" > > > + depends on CRASH_CORE > > > + default "1G-64G:128M,64G-1T:256M,1T-:512M" > > > + help > > > + This configures the reserved memory dependent > > > + on the value of System RAM. The syntax is: > > > + crashkernel=:[,:,...][@offset] > > > + range=start-[end] > > > + > > > + For example: > > > + crashkernel=512M-2G:64M,2G-:128M > > > + > > > + This would mean: > > > + > > > + 1) if the RAM is smaller than 512M, then don't reserve anything > > > + (this is the "rescue" case) > > > + 2) if the RAM size is between 512M and 2G (exclusive), then reserve 64M > > > + 3) if the RAM size is larger than 2G, then reserve 128M > > > + > > > +endif # CRASH_CORE > > > > Wondering if this CRASH_CORE ifdeffery is a little redundent here > > since CRASH_CORE dependency has been added. Except of this, I like this > > patch. As we discussed in private threads, we can try to push it into > > mainline and continue improving later. > > > > I believe "if CRASH_CORE" is not needed as it already "depends on > CRASH_CORE", tested with CRASH_CORE=y or 'not set', it just works. Thanks for testing and confirmation, Kairui. Saeed, can you post a v4 with CRASH_CORE ifdeffery removed? Maybe this week? Thanks Baoquan > > > > + > > > config KEXEC_CORE > > > select CRASH_CORE > > > bool > > > diff --git a/kernel/crash_core.c b/kernel/crash_core.c > > > index 106e4500fd53..ab0a2b4b1ffa 100644 > > > --- a/kernel/crash_core.c > > > +++ b/kernel/crash_core.c > > > @@ -7,6 +7,7 @@ > > > #include > > > #include > > > #include > > > +#include > > > > > > #include > > > #include > > > @@ -250,6 +251,12 @@ static int __init __parse_crashkernel(char *cmdline, > > > if (suffix) > > > return parse_crashkernel_suffix(ck_cmdline, crash_size, > > > suffix); > > > +#ifdef CONFIG_CRASH_AUTO_STR > > > + if (strncmp(ck_cmdline, "auto", 4) == 0) { > > > + ck_cmdline = CONFIG_CRASH_AUTO_STR; > > > + pr_info("Using crashkernel=auto, the size chosen is a best effort estimation.\n"); > > > + } > > > +#endif > > > /* > > > * if the commandline contains a ':', then that's the extended > > > * syntax -- if not, it must be the classic syntax > > > -- > > > 2.27.0 > > > > > > > > > _______________________________________________ > > kexec mailing list > > kexec@lists.infradead.org > > http://lists.infradead.org/mailman/listinfo/kexec > > > > > -- > Best Regards, > Kairui Song > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec