From: Baoquan He <bhe@redhat.com>
To: Tian Tao <tiantao6@hisilicon.com>
Cc: dyoung@redhat.com, kexec@lists.infradead.org, akpm@linux-foundation.org
Subject: Re: [PATCH] crash_dump: Fix duplicate included pgtable.h
Date: Tue, 23 Mar 2021 15:48:18 +0800 [thread overview]
Message-ID: <20210323074818.GA20547@MiWiFi-R3L-srv> (raw)
In-Reply-To: <1616155393-12188-1-git-send-email-tiantao6@hisilicon.com>
On 03/19/21 at 08:03pm, Tian Tao wrote:
> linux/pgtable.h is included more than once, Remove the one that isn't
> necessary.
>
> Fixes: ca5999fde0a1 ("mm: introduce include/linux/pgtable.h")
> Signed-off-by: Tian Tao <tiantao6@hisilicon.com>
Thanks, this looks good to me. But the Fixes tag is unnecessary since
this patch is a trivial cleanup, no need to add to stable kernel.
Otherwise,
Acked-by: Baoquan He <bhe@redhat.com>
> ---
> include/linux/crash_dump.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h
> index a5192b7..6bd8a33 100644
> --- a/include/linux/crash_dump.h
> +++ b/include/linux/crash_dump.h
> @@ -8,8 +8,6 @@
> #include <linux/pgtable.h>
> #include <uapi/linux/vmcore.h>
>
> -#include <linux/pgtable.h> /* for pgprot_t */
> -
> #ifdef CONFIG_CRASH_DUMP
> #define ELFCORE_ADDR_MAX (-1ULL)
> #define ELFCORE_ADDR_ERR (-2ULL)
> --
> 2.7.4
>
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2021-03-23 7:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-19 12:03 [PATCH] crash_dump: Fix duplicate included pgtable.h Tian Tao
2021-03-19 12:36 ` Baoquan He
2021-03-23 7:48 ` Baoquan He [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210323074818.GA20547@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=dyoung@redhat.com \
--cc=kexec@lists.infradead.org \
--cc=tiantao6@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox