From: Baoquan He <bhe@redhat.com>
To: Patrick Sung <patricksung@gmail.com>
Cc: kexec@lists.infradead.org, dyoung@redhat.com,
ebiederm@xmission.com, horms@verge.net.au
Subject: Re: kexec does not work for kernel version with patch level >= 256
Date: Wed, 31 Mar 2021 10:47:45 +0800 [thread overview]
Message-ID: <20210331024745.GB29970@MiWiFi-R3L-srv> (raw)
In-Reply-To: <CAK5_k=Lao5dYtAWrBMXViM0iEdT0QOj-fPiEsuvkfTogfF=6dA@mail.gmail.com>
On 03/24/21 at 12:28pm, Patrick Sung wrote:
> Hello all,
>
> I am using the 4.9 long term kernel which is currently at 4.9.262.
> When using this kernel with kexec-tools it prints out this error
>
> Unsupported utsname.release: 4.9.262
> Cannot load <kdump images path>
>
> A quick search in the code shows that kexec/kernel_version.c doing this check:
>
> if (major >= 256 || minor >= 256 || patch >= 256) {
>
> and also in kexec/kexec.h
> #define KERNEL_VERSION(major, minor, patch) \
> (((major) << 16) | ((minor) << 8) | patch)
Yeah, this seems to be a good catch. The existing longterm kenrel 4.9.262
does cause the problem. I am not very sure about the longterm kernel
version numbering, maybe we can leave 16 bits for for patch number to
avoid the longterm kernel issue?
Is there document telling the longterm kernel version numbering, or any
pointer?
Thanks
Baoquan
>
> which explains the reason for the range check in kernel_version.c
>
> Increasing the number of bits allowed in "patch" seems to fix the issue.
>
> Thanks,
> Patrick
>
> _______________________________________________
> kexec mailing list
> kexec@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/kexec
>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2021-03-31 2:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-24 4:28 kexec does not work for kernel version with patch level >= 256 Patrick Sung
2021-03-31 2:47 ` Baoquan He [this message]
2021-03-31 3:04 ` Patrick Sung
2021-03-31 3:48 ` Baoquan He
2021-03-31 8:03 ` Baoquan He
2021-03-31 8:10 ` Greg KH
2021-03-31 14:05 ` Eric W. Biederman
[not found] ` <CAO7dBbWPcjOTcugLkpV9S9uOEhetCg=MiW=xDbAX4EAotBMOHg@mail.gmail.com>
2021-04-01 17:50 ` Eric W. Biederman
[not found] ` <CAO7dBbU=Q7yMKv-Hp8cUxgPffE=vxtKYvfP7NLKejf-Q8x+H=w@mail.gmail.com>
2021-04-07 17:23 ` Eric W. Biederman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210331024745.GB29970@MiWiFi-R3L-srv \
--to=bhe@redhat.com \
--cc=dyoung@redhat.com \
--cc=ebiederm@xmission.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=patricksung@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox