From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mx2.suse.de ([195.135.220.15]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lUu4X-004ett-UW for kexec@lists.infradead.org; Fri, 09 Apr 2021 16:33:31 +0000 Date: Fri, 9 Apr 2021 18:33:24 +0200 From: Michal =?iso-8859-1?Q?Such=E1nek?= Subject: Re: [PATCHv5 2/2] powerpc/pseries: update device tree before ejecting hotplug uevents Message-ID: <20210409163323.GP6564@kitsune.suse.cz> References: <1597049570-19536-1-git-send-email-kernelfans@gmail.com> <1597049570-19536-2-git-send-email-kernelfans@gmail.com> <17369122-3e37-1360-0f68-827a8104cd35@linux.ibm.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Pingfan Liu Cc: Laurent Dufour , Nathan Lynch , Kexec Mailing List , Nathan Fontenot , linuxppc-dev , Hari Bathini Hello, On Fri, Aug 28, 2020 at 04:10:09PM +0800, Pingfan Liu wrote: > On Thu, Aug 27, 2020 at 3:53 PM Laurent Dufour wr= ote: > > > > Le 10/08/2020 =E0 10:52, Pingfan Liu a =E9crit : > > > A bug is observed on pseries by taking the following steps on rhel: > > > -1. drmgr -c mem -r -q 5 > > > -2. echo c > /proc/sysrq-trigger > > > > > > And then, the failure looks like: > > > kdump: saving to /sysroot//var/crash/127.0.0.1-2020-01-16-02:06:14/ > > > kdump: saving vmcore-dmesg.txt > > > kdump: saving vmcore-dmesg.txt complete > > > kdump: saving vmcore > > > Checking for memory holes : [ 0.0 %] / = Checking for memory holes : [100.0 %= ] | Excluding unnecessary pages : [= 100.0 %] \ Copying data = : [ 0.3 %] - eta: 38s[ 44.337636] hash-mmu: mm: Hashing fai= lure ! EA=3D0x7fffba400000 access=3D0x8000000000000004 current=3Dmakedumpfi= le > > > [ 44.337663] hash-mmu: trap=3D0x300 vsid=3D0x13a109c ssize=3D1 = base psize=3D2 psize 2 pte=3D0xc000000050000504 > > > [ 44.337677] hash-mmu: mm: Hashing failure ! EA=3D0x7fffba400000 ac= cess=3D0x8000000000000004 current=3Dmakedumpfile > > > [ 44.337692] hash-mmu: trap=3D0x300 vsid=3D0x13a109c ssize=3D1 = base psize=3D2 psize 2 pte=3D0xc000000050000504 > > > [ 44.337708] makedumpfile[469]: unhandled signal 7 at 00007fffba400= 000 nip 00007fffbbc4d7fc lr 000000011356ca3c code 2 > > > [ 44.338548] Core dump to |/bin/false pipe failed > > > /lib/kdump-lib-initramfs.sh: line 98: 469 Bus error $= CORE_COLLECTOR /proc/vmcore $_mp/$KDUMP_PATH/$HOST_IP-$DATEDIR/vmcore-incom= plete > > > kdump: saving vmcore failed > > > > > > * Root cause * > > > After analyzing, it turns out that in the current implementation, > > > when hot-removing lmb, the KOBJ_REMOVE event ejects before the dt upd= ating as > > > the code __remove_memory() comes before drmem_update_dt(). > > > So in kdump kernel, when read_from_oldmem() resorts to > > > pSeries_lpar_hpte_insert() to install hpte, but fails with -2 due to > > > non-exist pfn. And finally, low_hash_fault() raise SIGBUS to process,= as it > > > can be observed "Bus error" > > > > > > From a viewpoint of listener and publisher, the publisher notifies t= he > > > listener before data is ready. This introduces a problem where udev > > > launches kexec-tools (due to KOBJ_REMOVE) and loads a stale dt before > > > updating. And in capture kernel, makedumpfile will access the memory = based > > > on the stale dt info, and hit a SIGBUS error due to an un-existed lmb. > > > > > > * Fix * > > > This bug is introduced by commit 063b8b1251fd > > > ("powerpc/pseries/memory-hotplug: Only update DT once per memory DLPAR > > > request"), which tried to combine all the dt updating into one. > > > > > > To fix this issue, meanwhile not to introduce a quadratic runtime > > > complexity by the model: > > > dlpar_memory_add_by_count > > > for_each_drmem_lmb <-- > > > dlpar_add_lmb > > > drmem_update_dt(_v1|_v2) > > > for_each_drmem_lmb <-- > > > The dt should still be only updated once, and just before the last me= mory > > > online/offline event is ejected to user space. Achieve this by tracin= g the > > > num of lmb added or removed. > > > > > > Signed-off-by: Pingfan Liu > > > Cc: Michael Ellerman > > > Cc: Hari Bathini > > > Cc: Nathan Lynch > > > Cc: Nathan Fontenot > > > Cc: Laurent Dufour > > > To: linuxppc-dev@lists.ozlabs.org > > > Cc: kexec@lists.infradead.org > > > --- > > > v4 -> v5: change dlpar_add_lmb()/dlpar_remove_lmb() prototype to repo= rt > > > whether dt is updated successfully. > > > Fix a condition boundary check bug > > > v3 -> v4: resolve a quadratic runtime complexity issue. > > > This series is applied on next-test branch > > > arch/powerpc/platforms/pseries/hotplug-memory.c | 102 +++++++++++++= ++++++----- > > > 1 file changed, 80 insertions(+), 22 deletions(-) > > > > > > diff --git a/arch/powerpc/platforms/pseries/hotplug-memory.c b/arch/p= owerpc/platforms/pseries/hotplug-memory.c > > > index 46cbcd1..1567d9f 100644 > > > --- a/arch/powerpc/platforms/pseries/hotplug-memory.c > > > +++ b/arch/powerpc/platforms/pseries/hotplug-memory.c > > > @@ -350,13 +350,22 @@ static bool lmb_is_removable(struct drmem_lmb *= lmb) > > > return true; > > > } > > > > > > -static int dlpar_add_lmb(struct drmem_lmb *); > > > +enum dt_update_status { > > > + DT_NOUPDATE, > > > + DT_TOUPDATE, > > > + DT_UPDATED, > > > +}; > > > + > > > +/* "*dt_update" returns DT_UPDATED if updated */ > > > +static int dlpar_add_lmb(struct drmem_lmb *lmb, > > > + enum dt_update_status *dt_update); > > > > > > -static int dlpar_remove_lmb(struct drmem_lmb *lmb) > > > +static int dlpar_remove_lmb(struct drmem_lmb *lmb, > > > + enum dt_update_status *dt_update) > > > { > > > unsigned long block_sz; > > > phys_addr_t base_addr; > > > - int rc, nid; > > > + int rc, ret, nid; > > > > > > if (!lmb_is_removable(lmb)) > > > return -EINVAL; > > > @@ -372,6 +381,13 @@ static int dlpar_remove_lmb(struct drmem_lmb *lm= b) > > > invalidate_lmb_associativity_index(lmb); > > > lmb_clear_nid(lmb); > > > lmb->flags &=3D ~DRCONF_MEM_ASSIGNED; > > > + if (*dt_update) { > Original, I plan to use it to exclude the case of DT_NOUPDATE, which is v= alue 0. > And I think it looks better by using if (*dt_update =3D=3D DT_TOUPDATE) > > > > That test is wrong, you should do: > > if (*dt_update && *dt_update =3D=3D DT_TOUPDATE) { > I think you mean if (dt_update && *dt_update =3D=3D DT_TOUPDATE) { > > > > With the current code, the device tree is updated all the time. > > > > Another option would be to pass a valid pointer (!=3D NULL) only when D= T update is > > required, this way you don't need the DT_TOUPDATE value. The caller wou= ld have > > to set the pointer accordingly. The advantage with this option is the c= aller is > > guaranteed that its variable is not touched by the callee when no devic= e tree is > > requested. A simple boolean pointer would be enough without the need to= this enum. > It is expected that dlpar_remove_lmb/dlpar_add_lmb can report whether > they successfully update dt or not. So the caller can handle the > different cases. Is there any plan to refresh this patch to apply to master? I am using an older revision of this patch so I am not in the position to repost an updated version. I lack some otimization in my patch so I probably have the quadratic coplexity of the add mentioned above. Thanks Michal _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec