From: Russell King - ARM Linux admin <linux@armlinux.org.uk>
To: Alexander Egorenkov <egorenar-dev@posteo.net>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH 1/1] arm: do not copy magic 4 bytes of appended DTB in zImage
Date: Mon, 12 Apr 2021 11:52:35 +0100 [thread overview]
Message-ID: <20210412105235.GK1463@shell.armlinux.org.uk> (raw)
In-Reply-To: <20210408200644.19724-1-egorenar-dev@posteo.net>
On Thu, Apr 08, 2021 at 10:06:44PM +0200, Alexander Egorenkov wrote:
> If the passed zImage happens to have a DTB appended, then the magic 4 bytes
> of the DTB are copied together with the kernel image. This leads to
> failed kexec boots because the decompressor finds the aforementioned
> DTB magic and falsely tries to replace the DTB passed in the register r2
> with the non-existent appended one.
>
> Signed-off-by: Alexander Egorenkov <egorenar-dev@posteo.net>
This looks correct, but I would like a comment before the assignment
of kernel_buf_size to explain that this is the size of the compressed
kernel image excluding any appended DTB.
Thanks.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTP is here! 40Mbps down 10Mbps up. Decent connectivity at last!
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2021-04-12 10:55 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-08 20:06 [PATCH 1/1] arm: do not copy magic 4 bytes of appended DTB in zImage Alexander Egorenkov
2021-04-12 10:38 ` Simon Horman
2021-04-12 11:27 ` Alexander Egorenkov
2021-04-17 7:19 ` Simon Horman
2021-04-12 10:52 ` Russell King - ARM Linux admin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210412105235.GK1463@shell.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=egorenar-dev@posteo.net \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox