From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1md0po-0039nS-U2 for kexec@lists.infradead.org; Wed, 20 Oct 2021 01:56:07 +0000 Date: Wed, 20 Oct 2021 09:53:57 +0800 From: Baoquan He Subject: Re: [PATCH] crash_dump: remove duplicate include in crash_dump.h Message-ID: <20211020015357.GD27625@MiWiFi-R3L-srv> References: <20211020012318.1035952-1-ye.guojin@zte.com.cn> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211020012318.1035952-1-ye.guojin@zte.com.cn> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: cgel.zte@gmail.com Cc: dyoung@redhat.com, vgoyal@redhat.com, kexec@lists.infradead.org, linux-kernel@vger.kernel.org, Ye Guojin , Zeal Robot , rppt@linux.ibm.com On 10/20/21 at 01:23am, cgel.zte@gmail.com wrote: > From: Ye Guojin > > 'linux/pgtable.h' included in 'crash_dump.h' is duplicated. > it's also included at line 8. OK, in below commit the including order is adjusted, but the old one was not removed. commit 65fddcfca8ad("mm: reorder includes after introduction of linux/pgtable.h") Could you rephrase the commit log? , the below sentences is for your reference. ============ In crash_dump.h, header file linux/pgtable.h is included twice. This duplication was introduced in commit 65fddcfca8ad("mm: reorder includes after introduction of linux/pgtable.h") where the order of include is adjusted, while the old one was not removed. Clean it up here. ============ Thanks for fixing this. when you finish polishing the patch log, please feel free to add: Acked-by: Baoquan He Thanks Baoquan > > Reported-by: Zeal Robot > Signed-off-by: Ye Guojin > --- > include/linux/crash_dump.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/include/linux/crash_dump.h b/include/linux/crash_dump.h > index 0c547d866f1e..b7b255b23b99 100644 > --- a/include/linux/crash_dump.h > +++ b/include/linux/crash_dump.h > @@ -8,8 +8,6 @@ > #include > #include > > -#include /* for pgprot_t */ > - > /* For IS_ENABLED(CONFIG_CRASH_DUMP) */ > #define ELFCORE_ADDR_MAX (-1ULL) > #define ELFCORE_ADDR_ERR (-2ULL) > -- > 2.25.1 > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec