From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from us-smtp-delivery-124.mimecast.com ([170.10.129.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mntkm-009H1n-DO for kexec@lists.infradead.org; Fri, 19 Nov 2021 02:35:53 +0000 Date: Fri, 19 Nov 2021 10:35:31 +0800 From: Baoquan He Subject: Re: [PATCH v2 2/2] s390/kexec: fix kmemleak Message-ID: <20211119023531.GB12774@MiWiFi-R3L-srv> References: <20211116032557.14075-2-bhe@redhat.com> <202111180539.e7kmpOSP-lkp@intel.com> <20211118071327.GF21646@MiWiFi-R3L-srv> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: Heiko Carstens Cc: kernel test robot , linux-kernel@vger.kernel.org, kbuild-all@lists.01.org, linux-s390@vger.kernel.org, kexec@lists.infradead.org, prudo@redhat.com On 11/18/21 at 09:53am, Heiko Carstens wrote: > On Thu, Nov 18, 2021 at 03:13:27PM +0800, Baoquan He wrote: > > On 11/18/21 at 05:46am, kernel test robot wrote: > > > arch/s390/kernel/machine_kexec_file.c: In function 'arch_kimage_file_post_load_cleanup': > > > >> arch/s390/kernel/machine_kexec_file.c:332:9: error: implicit declaration of function 'kvfree'; did you mean 'vfree'? [-Werror=implicit-function-declaration] > > > 332 | kvfree(image->arch.ipl_buf); > > > | ^~~~~~ > > > | vfree > > > > OK, kvfree is not wrong, seems vfree is more appropriate since it's > > clear the ipl_buf is allocated with zvalloc() in ipl_report_finish(). > > > > Hi Heiko, > > > > Could you help modify the code in your tree or append below patch to > > mute the lkp complaint? Sorry for the inconvenience. > ... > > arch/s390/kernel/machine_kexec_file.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/arch/s390/kernel/machine_kexec_file.c b/arch/s390/kernel/machine_kexec_file.c > > index 7f51837e9bc2..351a7ff69a43 100644 > > --- a/arch/s390/kernel/machine_kexec_file.c > > +++ b/arch/s390/kernel/machine_kexec_file.c > > @@ -329,7 +329,7 @@ int arch_kexec_apply_relocations_add(struct purgatory_info *pi, > > > > int arch_kimage_file_post_load_cleanup(struct kimage *image) > > { > > - kvfree(image->arch.ipl_buf); > > + vfree(image->arch.ipl_buf); > > The problem reported above indicates that slab.h was not > included. With your patch, while it fixes the problem for this > particular configuration, this requires vmalloc.h to be included. Indeed, thanks. > > I'll merge your patch and add the missing include as well. > _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec