From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from verein.lst.de ([213.95.11.211]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mwgIX-008D2E-4O for kexec@lists.infradead.org; Mon, 13 Dec 2021 08:03:02 +0000 Date: Mon, 13 Dec 2021 09:02:57 +0100 From: Christoph Hellwig Subject: Re: [PATCH 3/3] vmcore: Convert read_from_oldmem() to take an iov_iter Message-ID: <20211213080257.GC20986@lst.de> References: <20211213000636.2932569-1-willy@infradead.org> <20211213000636.2932569-4-willy@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20211213000636.2932569-4-willy@infradead.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+dwmw2=infradead.org@lists.infradead.org To: "Matthew Wilcox (Oracle)" Cc: Baoquan He , Vivek Goyal , Dave Young , kexec@lists.infradead.org, Tiezhu Yang , linux-kernel@vger.kernel.org, Amit Daniel Kachhap , Christoph Hellwig , linux-s390@vger.kernel.org, linux-fsdevel@vger.kernel.org > > ssize_t elfcorehdr_read(char *buf, size_t count, u64 *ppos) > { > - return read_from_oldmem(buf, count, ppos, 0, > + struct kvec kvec = { .iov_base = buf, .iov_len = count }; > + struct iov_iter iter; > + > + iov_iter_kvec(&iter, READ, &kvec, 1, count); > + > + return read_from_oldmem(&iter, count, ppos, > cc_platform_has(CC_ATTR_GUEST_MEM_ENCRYPT)); > } elfcorehdr_read should probably also take an iov_iter while we're at it. I also don't quite understand why we even need the arch overrides for it, but that would require some digging into the history of this interface. _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec