From: Coiby Xu <coxu@redhat.com>
To: Sourabh Jain <sourabhjain@linux.ibm.com>
Cc: kexec@lists.infradead.org, horms@verge.net.au, hbathini@linux.ibm.com
Subject: Re: [PATCH] ppc64: remove rma_top limit
Date: Tue, 20 Sep 2022 15:14:47 +0800 [thread overview]
Message-ID: <20220920071447.om36ms2leara2o2v@Rk> (raw)
In-Reply-To: <20220915084240.133742-1-sourabhjain@linux.ibm.com>
Hi,
I'm curious to ask which bug this patch is going to fix. I tested it
yesterday and it doesn't fix
https://bugzilla.redhat.com/show_bug.cgi?id=2126409.
On Thu, Sep 15, 2022 at 02:12:40PM +0530, Sourabh Jain wrote:
>Restricting kexec tool to allocate hole for kexec segments below 768MB
>may not be relavent now since first memory block size can be 1024MB and
>more.
>
>Removing rma_top restriction will give more space to find holes for
>kexec segments and existing in-place checks make sure that kexec segment
>allocation doesn't cross the first memory block because every kexec segment
>has to be within first memory block for kdump kernel to boot properly.
>
>Signed-off-by: Sourabh Jain <sourabhjain@linux.ibm.com>
>---
> kexec/arch/ppc64/kexec-ppc64.c | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/kexec/arch/ppc64/kexec-ppc64.c b/kexec/arch/ppc64/kexec-ppc64.c
>index 5b17740..611809f 100644
>--- a/kexec/arch/ppc64/kexec-ppc64.c
>+++ b/kexec/arch/ppc64/kexec-ppc64.c
>@@ -717,8 +717,6 @@ static int get_devtree_details(unsigned long kexec_flags)
> if (base < rma_base) {
> rma_base = base;
> rma_top = base + be64_to_cpu(((uint64_t *)buf)[1]);
>- if (rma_top > 0x30000000UL)
>- rma_top = 0x30000000UL;
> }
>
> fclose(file);
>--
>2.37.3
>
>
>_______________________________________________
>kexec mailing list
>kexec@lists.infradead.org
>http://lists.infradead.org/mailman/listinfo/kexec
>
--
Best regards,
Coiby
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2022-09-20 7:18 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-09-15 8:42 [PATCH] ppc64: remove rma_top limit Sourabh Jain
2022-09-16 10:58 ` Hari Bathini
2022-09-20 4:51 ` Sourabh Jain
2022-09-20 7:14 ` Coiby Xu [this message]
2022-09-24 12:10 ` Simon Horman
2022-09-29 6:49 ` Sourabh Jain
2022-10-05 15:20 ` Simon Horman
2022-09-28 10:42 ` Sourabh Jain
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20220920071447.om36ms2leara2o2v@Rk \
--to=coxu@redhat.com \
--cc=hbathini@linux.ibm.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=sourabhjain@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox