From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 80056C4332F for ; Sat, 17 Dec 2022 15:31:16 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=qmpfg7QFGAodtP11va3BlGJaj4xQNBr+BUOR5ybay5o=; b=RHJal3opKg0AVG vK2St22HS50nk1IG0WsY73QMcLDTF2U0vAVgDFZWkqpQ0zHJ5wcntCuk6hA8Fp8JTntwoY3IuJcrd NZ8jMrUENhe9rcWdtwCNpFl3AUToMkA3zRtLfFwb0X0Ci6jIz9j4uxHrOWis+P3loETdNeYqWAsgC LTcAk3/4vMXD5nAlwZku/FH7KVikOEuFOe1YXebalSzP6nmrnS+kws9Nw30Jfp27J8aPniL4GXIxv RgM2/ob2xHipxonkKKKFOc4UMAm9exUDceBTBCbpI9Z91pL0U09uLyLV8YUDGOsCepyMLDWcPXB82 Gv9GrxqKAd8T/6PT0zKA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6Z9b-00Ab8j-OO; Sat, 17 Dec 2022 15:31:11 +0000 Received: from dfw.source.kernel.org ([2604:1380:4641:c500::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p6Z9V-00Ab5m-DU for kexec@lists.infradead.org; Sat, 17 Dec 2022 15:31:09 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id DFBCC60C1A; Sat, 17 Dec 2022 15:31:04 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A7EEAC433EF; Sat, 17 Dec 2022 15:31:02 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1671291064; bh=guawvCvqoCRysW/sRWrLbLUwVFJLoIFBLF09VjrXsR0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=EwVp7crxy/uhgKllMelW7wc4NqaqAoB5ZIvW+BmhCaW5w8FV5OfWZlo7Lk18ajYXW UxgDBv3DqWK5mycwlJqu+hM3xnu2Rx2s7GUxQgl3WAwhpu/kqSLPgYOkJiysFYE28B Dhq6KawKIgP77/1j5WjT5d4blmr+cJfnChafTwiPkudj10mdadQkGxDTZpA8O1EDI0 FUExEXJGRKrvQX6HW3TiqjtyA8FBc4Mq778x9Wadx3OnZMQJcvpDrU9MIMc9QKlIMT 1HLk99DXj/NHyqIs4O8UmkzIJ2UhUbv6AlpB/Jj5CD8Ca5dL54AK7M5slISTC+jRu4 vcB3v4QsoGp5A== From: Sasha Levin To: linux-kernel@vger.kernel.org, stable@vger.kernel.org Cc: Jianglei Nie , Baoquan He , Benjamin Herrenschmidt , Chen Lifu , "Eric W . Biederman" , Li Chen , Michael Ellerman , Paul Mackerras , Petr Mladek , Russell King , ye xingchen , Zeal Robot , Andrew Morton , Sasha Levin , kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org Subject: [PATCH AUTOSEL 4.9 5/8] proc/vmcore: fix potential memory leak in vmcore_init() Date: Sat, 17 Dec 2022 10:30:49 -0500 Message-Id: <20221217153053.99513-5-sashal@kernel.org> X-Mailer: git-send-email 2.35.1 In-Reply-To: <20221217153053.99513-1-sashal@kernel.org> References: <20221217153053.99513-1-sashal@kernel.org> MIME-Version: 1.0 X-stable: review X-Patchwork-Hint: Ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221217_073108_463094_3AA226CF X-CRM114-Status: GOOD ( 12.91 ) X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org From: Jianglei Nie [ Upstream commit 12b9d301ff73122aebd78548fa4c04ca69ed78fe ] Patch series "Some minor cleanup patches resent". The first three patches trivial clean up patches. And for the patch "kexec: replace crash_mem_range with range", I got a ibm-p9wr ppc64le system to test, it works well. This patch (of 4): elfcorehdr_alloc() allocates a memory chunk for elfcorehdr_addr with kzalloc(). If is_vmcore_usable() returns false, elfcorehdr_addr is a predefined value. If parse_crash_elf_headers() gets some error and returns a negetive value, the elfcorehdr_addr should be released with elfcorehdr_free(). Fix it by calling elfcorehdr_free() when parse_crash_elf_headers() fails. Link: https://lkml.kernel.org/r/20220929042936.22012-1-bhe@redhat.com Link: https://lkml.kernel.org/r/20220929042936.22012-2-bhe@redhat.com Signed-off-by: Jianglei Nie Signed-off-by: Baoquan He Acked-by: Baoquan He Cc: Benjamin Herrenschmidt Cc: Chen Lifu Cc: "Eric W . Biederman" Cc: Li Chen Cc: Michael Ellerman Cc: Paul Mackerras Cc: Petr Mladek Cc: Russell King Cc: ye xingchen Cc: Zeal Robot Signed-off-by: Andrew Morton Signed-off-by: Sasha Levin --- fs/proc/vmcore.c | 1 + 1 file changed, 1 insertion(+) diff --git a/fs/proc/vmcore.c b/fs/proc/vmcore.c index e8b40835770c..76d60555d1c3 100644 --- a/fs/proc/vmcore.c +++ b/fs/proc/vmcore.c @@ -1177,6 +1177,7 @@ static int __init vmcore_init(void) return rc; rc = parse_crash_elf_headers(); if (rc) { + elfcorehdr_free(elfcorehdr_addr); pr_warn("Kdump: vmcore not initialized\n"); return rc; } -- 2.35.1 _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec