From: Andrew Morton <akpm@linux-foundation.org>
To: Sasha Levin <sashal@kernel.org>
Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org,
Jianglei Nie <niejianglei2021@163.com>,
Baoquan He <bhe@redhat.com>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Chen Lifu <chenlifu@huawei.com>,
"Eric W . Biederman" <ebiederm@xmission.com>,
Li Chen <lchen@ambarella.com>,
Michael Ellerman <mpe@ellerman.id.au>,
Paul Mackerras <paulus@samba.org>, Petr Mladek <pmladek@suse.com>,
Russell King <linux@armlinux.org.uk>,
ye xingchen <ye.xingchen@zte.com.cn>,
Zeal Robot <zealci@zte.com.cn>,
kexec@lists.infradead.org, linux-fsdevel@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Subject: Re: [PATCH AUTOSEL 6.1 13/22] proc/vmcore: fix potential memory leak in vmcore_init()
Date: Sat, 17 Dec 2022 16:32:28 -0800 [thread overview]
Message-ID: <20221217163228.9308c293458ceb680a6ffed8@linux-foundation.org> (raw)
In-Reply-To: <20221217152727.98061-13-sashal@kernel.org>
On Sat, 17 Dec 2022 10:27:14 -0500 Sasha Levin <sashal@kernel.org> wrote:
> From: Jianglei Nie <niejianglei2021@163.com>
>
> [ Upstream commit 12b9d301ff73122aebd78548fa4c04ca69ed78fe ]
>
> Patch series "Some minor cleanup patches resent".
>
> The first three patches trivial clean up patches.
>
> And for the patch "kexec: replace crash_mem_range with range", I got a
> ibm-p9wr ppc64le system to test, it works well.
>
> This patch (of 4):
>
> elfcorehdr_alloc() allocates a memory chunk for elfcorehdr_addr with
> kzalloc(). If is_vmcore_usable() returns false, elfcorehdr_addr is a
> predefined value. If parse_crash_elf_headers() gets some error and
> returns a negetive value, the elfcorehdr_addr should be released with
> elfcorehdr_free().
This is exceedingly minor - a single memory leak per boot, under very
rare circumstances.
With every patch I merge I consider -stable. Often I'll discuss the
desirability of a backport with the author and with reviewers. Every
single patch. And then some damn script comes along and overrides that
quite careful decision. argh.
Can we please do something like
if (akpm && !cc:stable)
dont_backport()
And even go further - if your script thinks it might be something we
should backport and if it didn't have cc:stable then contact the
author, reviewers and committers and ask them to reconsider before we
go and backport it. This approach will have the advantage of training
people to consider the backport more consistently.
I'd (still) like to have a new patch tag like Not-For-Stable: or
cc:not-stable or something to tell your scripts "yes, we thought about
it and we decided no".
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next prev parent reply other threads:[~2022-12-18 0:32 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20221217152727.98061-1-sashal@kernel.org>
2022-12-17 15:27 ` [PATCH AUTOSEL 6.1 13/22] proc/vmcore: fix potential memory leak in vmcore_init() Sasha Levin
2022-12-18 0:32 ` Andrew Morton [this message]
2022-12-18 11:28 ` Sasha Levin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20221217163228.9308c293458ceb680a6ffed8@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=benh@kernel.crashing.org \
--cc=bhe@redhat.com \
--cc=chenlifu@huawei.com \
--cc=ebiederm@xmission.com \
--cc=gregkh@linuxfoundation.org \
--cc=kexec@lists.infradead.org \
--cc=lchen@ambarella.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=mpe@ellerman.id.au \
--cc=niejianglei2021@163.com \
--cc=paulus@samba.org \
--cc=pmladek@suse.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=ye.xingchen@zte.com.cn \
--cc=zealci@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox