Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Eric DeVolder <eric.devolder@oracle.com>
To: kexec@lists.infradead.org
Cc: boris.ostrovsky@oracle.com, eric.devolder@oracle.com
Subject: [PATCH v2 4/6] crashdump: exclude elfcorehdr segment from digest for hotplug
Date: Wed,  3 May 2023 18:16:09 -0400	[thread overview]
Message-ID: <20230503221611.2119-5-eric.devolder@oracle.com> (raw)
In-Reply-To: <20230503221611.2119-1-eric.devolder@oracle.com>

To allow direct modification of the elfcorehdr by the kernel, in
response to CPU and memory hot un/plug and/or online/offline events,
the buffer containing the elfcorehdr must be excluded from the
purgatory checksum/digest.

Signed-off-by: Eric DeVolder <eric.devolder@oracle.com>
---
 kexec/kexec.c | 8 ++++++++
 kexec/kexec.h | 1 +
 2 files changed, 9 insertions(+)

diff --git a/kexec/kexec.c b/kexec/kexec.c
index c59e795..9d0d6cb 100644
--- a/kexec/kexec.c
+++ b/kexec/kexec.c
@@ -674,6 +674,14 @@ static void update_purgatory(struct kexec_info *info)
 		if (info->segment[i].mem == (void *)info->rhdr.rel_addr) {
 			continue;
 		}
+
+		/* Don't include elfcorehdr in the checksum, if hotplug
+		 * support enabled.
+		 */
+		if (do_hotplug && (info->segment[i].mem == (void *)info->elfcorehdr)) {
+			continue;
+		}
+
 		sha256_update(&ctx, info->segment[i].buf,
 			      info->segment[i].bufsz);
 		nullsz = info->segment[i].memsz - info->segment[i].bufsz;
diff --git a/kexec/kexec.h b/kexec/kexec.h
index fc24b67..8acbdc1 100644
--- a/kexec/kexec.h
+++ b/kexec/kexec.h
@@ -169,6 +169,7 @@ struct kexec_info {
 	int command_line_len;
 
 	int skip_checks;
+	unsigned long elfcorehdr;
 };
 
 struct arch_map_entry {
-- 
2.31.1


_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  parent reply	other threads:[~2023-05-03 22:16 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-05-03 22:16 [PATCH v2 0/6] crashdump: Kernel handling of CPU and memory hot un/plug Eric DeVolder
2023-05-03 22:16 ` [PATCH v2 1/6] kexec: define KEXEC_UPDATE_ELFCOREHDR Eric DeVolder
2023-05-03 22:16 ` [PATCH v2 2/6] crashdump: introduce the hotplug command line options Eric DeVolder
2023-05-03 22:16 ` [PATCH v2 3/6] crashdump: setup hotplug support Eric DeVolder
2023-05-03 22:16 ` Eric DeVolder [this message]
2023-05-03 22:16 ` [PATCH v2 5/6] crashdump/x86: identify elfcorehdr segment for hotplug Eric DeVolder
2023-05-03 22:16 ` [PATCH v2 6/6] crashdump/x86: set the elfcorehdr segment size " Eric DeVolder
2023-05-04  6:19 ` [PATCH v2 0/6] crashdump: Kernel handling of CPU and memory hot un/plug Hari Bathini

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20230503221611.2119-5-eric.devolder@oracle.com \
    --to=eric.devolder@oracle.com \
    --cc=boris.ostrovsky@oracle.com \
    --cc=kexec@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox