Re: [PATCH] kexec: ppc64: print help to stdout instead of stderr

[Srikar Dronamraju <srikar@linux.vnet.ibm.com>]

* Aditya Gupta <adityag@linux.ibm.com> [2023-11-16 14:11:37]:

> Currently 'kexec --help' on powerpc64 prints the generic help/usage to
> stdout, and the powerpc64 specific options to stderr
> 
> That is, if the stdout of 'kexec --help' is redirected to some file,
> some of the help options will not be redirected, and instead printed on
> the terminal/stderr:
> 
>     [root@machine kexec-tools]# kexec --help > /tmp/out
>          --command-line=<Command line> command line to append.
>          --append=<Command line> same as --command-line.
>          --ramdisk=<filename> Initial RAM disk.
>          --initrd=<filename> same as --ramdisk.
>          --devicetreeblob=<filename> Specify device tree blob file.
>                                      Not applicable while using
>     --kexec-file-syscall.
>          --dtb=<filename> same as --devicetreeblob.
>     elf support is still broken
>          --elf64-core-headers Prepare core headers in ELF64 format
>          --dt-no-old-root Do not reuse old kernel root= param.
>                           while creating flatten device tree.
> 
> Fix this inconsistency by writing powerpc64 specific options to stdout,
> similar to the generic 'kexec --help'
> 
> With the proposed changes, it is like this (nothing printed to stderr):
> 
>     [root@machine kexec-tools]# ./build/sbin/kexec --help > /tmp/out
> 
> Reported-by: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
> Signed-off-by: Aditya Gupta <adityag@linux.ibm.com>
> ---

Thanks Aditya for looking into this.

-- 
Thanks and Regards
Srikar Dronamraju

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec