From: Baoquan He <bhe@redhat.com>
To: kexec@lists.infradead.org
Cc: horms@kernel.org, Baoquan He <bhe@redhat.com>
Subject: [PATCH] util_lib/elf_info.c: fix a warning
Date: Thu, 21 Mar 2024 15:30:37 +0800 [thread overview]
Message-ID: <20240321073037.823696-1-bhe@redhat.com> (raw)
There's a incorrect array operation in function scan_vmcoreinfo(), it
will cause below warning message.
-----------------------
util_lib/elf_info.c: In function ‘scan_vmcoreinfo’:
util_lib/elf_info.c:360:43: warning: writing 1 byte into a region of size 0 [-Wstringop-overflow=]
360 | temp_buf[len + 1] = '\0';
| ~~~~~~~~~~~~~~~~~~^~~~~~
util_lib/elf_info.c:319:14: note: at offset 1024 into destination object ‘temp_buf’ of size 1024
319 | char temp_buf[1024];
| ^~~~~~~~
---------------------
Fix it to avoid oob access of array.
Signed-off-by: Baoquan He <bhe@redhat.com>
---
util_lib/elf_info.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/util_lib/elf_info.c b/util_lib/elf_info.c
index ce71c6055c3a..7ca9870bfca0 100644
--- a/util_lib/elf_info.c
+++ b/util_lib/elf_info.c
@@ -357,7 +357,7 @@ void scan_vmcoreinfo(char *start, size_t size)
if (len >= sizeof(temp_buf))
len = sizeof(temp_buf) - 1;
strncpy(temp_buf, pos, len);
- temp_buf[len + 1] = '\0';
+ temp_buf[len] = '\0';
pos = temp_buf;
len = len + 1;
--
2.41.0
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
next reply other threads:[~2024-03-21 7:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-03-21 7:30 Baoquan He [this message]
2024-03-22 21:09 ` [PATCH] util_lib/elf_info.c: fix a warning Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240321073037.823696-1-bhe@redhat.com \
--to=bhe@redhat.com \
--cc=horms@kernel.org \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox