From: Simon Horman <horms@kernel.org>
To: Julien Olivain <ju.o@free.fr>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH 1/1] s390: add missing limits.h header inclusion
Date: Tue, 23 Jul 2024 10:58:50 +0100 [thread overview]
Message-ID: <20240723095850.GD24657@kernel.org> (raw)
In-Reply-To: <20240719174744.549913-1-ju.o@free.fr>
On Fri, Jul 19, 2024 at 07:47:44PM +0200, Julien Olivain wrote:
> Commit b84fcdd48c [1] introduced a usage of PATH_MAX in file
> "kexec-s390.c". This constant is defined in the <limits.h> header.
> See [2].
>
> With some libc, such as musl, kexec-tools fails to build with output:
>
> kexec/arch/s390/kexec-s390.c: In function 'remove_offline_memory':
> kexec/arch/s390/kexec-s390.c:120:19: error: 'PATH_MAX' undeclared (first use in this function)
> 120 | char path[PATH_MAX];
> | ^~~~~~~~
>
> The issue can be reproduced, for example, with Buildroot Linux, using
> a s390 gcc toolchain with the musl libc and the following commands:
>
> git clone -b 2024.05.1 --depth 1 https://gitlab.com/buildroot.org/buildroot.git
> cd buildroot
> cat > .config <<EOF
> BR2_s390x=y
> BR2_TOOLCHAIN_BUILDROOT_MUSL=y
> BR2_PACKAGE_KEXEC=y
> EOF
> make olddefconfig
> make
>
> Note: in this test, kexec-tools v2.0.28 is used.
>
> This commit fixes the issue by adding the missing header inclusion.
>
> [1] https://git.kernel.org/pub/scm/utils/kernel/kexec/kexec-tools.git/commit/?id=b84fcdd48cbe70e54e66f2cf1b251e0db58f04f4
> [2] https://pubs.opengroup.org/onlinepubs/9699919799/basedefs/limits.h.html
>
> Signed-off-by: Julien Olivain <ju.o@free.fr>
Thanks Julien, applied.
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2024-07-23 9:59 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-19 17:47 [PATCH 1/1] s390: add missing limits.h header inclusion Julien Olivain
2024-07-23 9:58 ` Simon Horman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240723095850.GD24657@kernel.org \
--to=horms@kernel.org \
--cc=ju.o@free.fr \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox