From: Aditya Gupta <adityag@linux.ibm.com>
To: <kexec@lists.infradead.org>
Subject: [PATCH] fix comment: Mention current logic for vmalloc_start
Date: Thu, 1 Aug 2024 12:52:27 +0530 [thread overview]
Message-ID: <20240801072227.40562-1-adityag@linux.ibm.com> (raw)
Previous comment is not valid anymore as for newer kernels we are
getting vmalloc_start from NUMBER(vmalloc_start)
The logic was changed in makedumpfile:
commit 94241fd2feed ("[PATCH] ppc64: get vmalloc start address from vmcoreinfo")
Fix comment for better understanding.
Signed-off-by: Aditya Gupta <adityag@linux.ibm.com>
---
repository: makedumpfile
patch should apply on commit 900190de6b67b2de410cfc8023c1b198a416ceb3
---
---
arch/ppc64.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/arch/ppc64.c b/arch/ppc64.c
index a54f9a04db7f..8ad9d6e3265f 100644
--- a/arch/ppc64.c
+++ b/arch/ppc64.c
@@ -566,7 +566,9 @@ get_machdep_info_ppc64(void)
DEBUG_MSG("kernel_start : %lx\n", info->kernel_start);
/*
- * Get vmalloc_start value from either vmap_area_list or vmlist.
+ * To get vmalloc_start, prefer NUMBER(vmalloc_start) if exported in
+ * vmcoreinfo, as 'vmap_area_list' and 'vmlist' in Linux 6.9 and later
+ * kernels might be empty
*/
if (NUMBER(vmalloc_start) != NOT_FOUND_NUMBER) {
vmalloc_start = NUMBER(vmalloc_start);
--
2.45.2
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
reply other threads:[~2024-08-01 7:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20240801072227.40562-1-adityag@linux.ibm.com \
--to=adityag@linux.ibm.com \
--cc=kexec@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox