Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Pingfan Liu <piliu@redhat.com>
Cc: Eric Biederman <ebiederm@xmission.com>,
	Baoquan He <bhe@redhat.com>, Dave Young <dyoung@redhat.com>,
	Ard Biesheuvel <ardb@kernel.org>,
	Jan Hendrik Farr <kernel@jfarr.cc>,
	Philipp Rudo <prudo@redhat.com>,
	Lennart Poettering <mzxreary@0pointer.de>,
	kexec@lists.infradead.org
Subject: Re: [PATCH 2/3] kexec: Introduce UKI image parser
Date: Fri, 11 Oct 2024 09:44:06 +0100	[thread overview]
Message-ID: <20241011084406.GB66815@kernel.org> (raw)
In-Reply-To: <20241008115408.21944-3-piliu@redhat.com>

On Tue, Oct 08, 2024 at 07:54:02PM +0800, Pingfan Liu wrote:
> A UKI image is a PE file that consists of several sections, typically
> including: .text, .data, .linux, .initrd, .cmdline, and others.
> 
> The kernel image is stored in the .linux section, which is one of the
> formats currently recognized by kexec-tools. Therefore, the UKI parser
> can be used to strip away the UKI layer, allowing the other parser to
> process the kernel image.
> 
> Signed-off-by: Pingfan Liu <piliu@redhat.com>
> Cc: Simon Horman <horms@kernel.org>
> Cc: Eric Biederman <ebiederm@xmission.com>
> Cc: Baoquan He <bhe@redhat.com>
> Cc: Dave Young <dyoung@redhat.com>
> Cc: kexec@lists.infradead.org
> ---
>  include/pe.h      | 104 +++++++++++++++++++++++++++++++++++++++
>  kexec/Makefile    |   1 +
>  kexec/kexec-uki.c | 122 ++++++++++++++++++++++++++++++++++++++++++++++
>  kexec/kexec.h     |   4 ++
>  4 files changed, 231 insertions(+)
>  create mode 100644 include/pe.h
>  create mode 100644 kexec/kexec-uki.c

Hi Pingfan Liu,

I think you need to squash the following into this patch
so that pe.h is included in distribution tarballs.

You should be able to see the problem by running: make distcheck.

diff --git a/include/Makefile b/include/Makefile
index cd88a26b1476..6a3e8541c36d 100644
--- a/include/Makefile
+++ b/include/Makefile
@@ -8,6 +8,7 @@ dist += include/Makefile		\
 	include/x86/mb_header.h		\
 	include/x86/multiboot2.h	\
 	include/elf.h			\
+	include/pe.h			\
 	include/image.h			\
 	include/unused.h		\
 	include/boot/linuxbios_tables.h	\

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

  reply	other threads:[~2024-10-11  8:45 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-10-08 11:54 [PATCH 0/3] kexec: Add support for UKI format kernel Pingfan Liu
2024-10-08 11:54 ` [PATCH 1/3] kexec: Introduce default_initrd_fd to pass internal initrd information Pingfan Liu
2024-10-08 11:54 ` [PATCH 2/3] kexec: Introduce UKI image parser Pingfan Liu
2024-10-11  8:44   ` Simon Horman [this message]
2024-10-11 11:14     ` Pingfan Liu
2024-10-14  2:43       ` Pingfan Liu
2024-10-15 13:26         ` Simon Horman
2024-10-16 11:37           ` Pingfan Liu
2024-10-08 11:54 ` [PATCH 3/3] arm64: Support UKI image format Pingfan Liu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241011084406.GB66815@kernel.org \
    --to=horms@kernel.org \
    --cc=ardb@kernel.org \
    --cc=bhe@redhat.com \
    --cc=dyoung@redhat.com \
    --cc=ebiederm@xmission.com \
    --cc=kernel@jfarr.cc \
    --cc=kexec@lists.infradead.org \
    --cc=mzxreary@0pointer.de \
    --cc=piliu@redhat.com \
    --cc=prudo@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox