Re: [PATCH 0/3] Enable UKI image load on x86_64

[Simon Horman <horms@kernel.org>]

On Fri, Nov 22, 2024 at 10:12:35AM +0800, Dave Young wrote:
> Hi Pingfan,
> 
> On Tue, 5 Nov 2024 at 11:57, Pingfan Liu <piliu@redhat.com> wrote:
> >
> > The correct kernel fd instead of UKI image fd should be
> > passed to the syscall. On arm64, it is not a problem, but on x86_64, it
> > is.(see commit log in 2/3)
> >
> > This series aims to address the above problem.
> >
> > Cc: Simon Horman <horms@kernel.org>
> > Cc: Philipp Rudo <prudo@redhat.com>
> > To: kexec@lists.infradead.org
> >
> > Pingfan Liu (3):
> >   UKI: Split out the routine to create temporary fd
> >   kexec: Create a temporary file to hold .linux section in uki_probe()
> >   x86_64: Support UKI image format
> 
> After Doing a test based on this series,   I noticed the uki load will
> not use the uki internal .cmdline for kernel command line parameters,
> it requires people to specify cmdline with kexec.  I think this is
> helpful for kdump to use.  But for general use it would be better to
> do something like:
> 
> by default use the UKI internal cmdline
> If one specify --command-line or --reuse-cmdline then just use the
> user provided cmdline and ignore the UKI internal cmdline.
> 
> Anyway this can be improved in the future as an appending patch,  the
> functionality works for me.
> 
> Acked-by: Dave Young <dyoung@redhat.com>

Thanks,

I will plan to apply this after v2.0.30 has been released.