From: Simon Horman <horms@kernel.org>
To: Arnd Bergmann <arnd@kernel.org>
Cc: Alexander Graf <graf@amazon.com>, Mike Rapoport <rppt@kernel.org>,
Changyuan Lyu <changyuanl@google.com>,
Andrew Morton <akpm@linux-foundation.org>,
Baoquan He <bhe@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kexec: include asm/early_ioremap.h
Date: Thu, 24 Apr 2025 10:23:44 +0100 [thread overview]
Message-ID: <20250424092344.GC3042781@horms.kernel.org> (raw)
In-Reply-To: <20250423162924.2213664-1-arnd@kernel.org>
On Wed, Apr 23, 2025 at 06:29:18PM +0200, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> The early_memremap() function is decleared in a header that is only indirectly
> included here:
>
> kernel/kexec_handover.c:1116:8: error: call to undeclared function 'early_memremap'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
> 1116 | fdt = early_memremap(fdt_phys, fdt_len);
> | ^
>
> Fixes: 4bfe738ce89a ("kexec: add KHO support to kexec file loads")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Hi Arnd,
I didn't try to reproduce this problem. And perhaps this isn't particularly
important. But, naively, I would have expected the following as it is
the commit the introduces calls to early_memremap() in exec_handover.c.
Fixes: b0a311dba688 ("kexec: add KHO parsing support")
next prev parent reply other threads:[~2025-04-24 11:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-23 16:29 [PATCH] kexec: include asm/early_ioremap.h Arnd Bergmann
2025-04-24 9:23 ` Simon Horman [this message]
2025-04-24 9:33 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250424092344.GC3042781@horms.kernel.org \
--to=horms@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bhe@redhat.com \
--cc=changyuanl@google.com \
--cc=graf@amazon.com \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rppt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).