public inbox for kexec@lists.infradead.org
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Baoquan He <bhe@redhat.com>
Cc: Li Chen <me@linux.beauty>, Mimi Zohar <zohar@linux.ibm.com>,
	Tushar Sugandhi <tusharsu@linux.microsoft.com>,
	Eric Biggers <ebiggers@kernel.org>,
	Alexander Graf <graf@amazon.com>,
	Steven Chen <chenste@linux.microsoft.com>,
	Coiby Xu <coxu@redhat.com>,
	Sourabh Jain <sourabhjain@linux.ibm.com>,
	Philipp Rudo <prudo@redhat.com>,
	Ricardo Ribalda <ribalda@chromium.org>,
	"Steven Rostedt (Google)" <rostedt@goodmis.org>,
	Ross Zwisler <zwisler@google.com>,
	kexec@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] kexec: derive purgatory entry from symbol
Date: Wed, 28 Jan 2026 11:19:29 -0800	[thread overview]
Message-ID: <20260128111929.73a13cc2d51ef113a586993e@linux-foundation.org> (raw)
In-Reply-To: <aXnWMmyUMdbrqAiu@MiWiFi-R3L-srv>

On Wed, 28 Jan 2026 17:26:10 +0800 Baoquan He <bhe@redhat.com> wrote:

> On 01/28/26 at 12:35pm, Li Chen wrote:
> > kexec_load_purgatory() derives image->start by locating e_entry inside an
> > SHF_EXECINSTR section. If the purgatory object contains multiple executable
> > sections with overlapping sh_addr, the entrypoint check can match more than
> > once and trigger a WARN.
> > 
> > Derive the entry section from the purgatory_start symbol when present and
> > compute image->start from its final placement. Keep the existing e_entry
> > fallback for purgatories that do not expose the symbol.
> > 
> > WARNING: kernel/kexec_file.c:1009 at kexec_load_purgatory+0x395/0x3c0, CPU#10: kexec/1784
> > Call Trace:
> >  <TASK>
> >  bzImage64_load+0x133/0xa00
> >  __do_sys_kexec_file_load+0x2b3/0x5c0
> >  do_syscall_64+0x81/0x610
> >  entry_SYSCALL_64_after_hwframe+0x76/0x7e
> > 
> > Fixes: 8652d44f466a ("kexec: support purgatories with .text.hot sections")
> > Signed-off-by: Li Chen <me@linux.beauty>
> 
> LGTM,
> 
> Acked-by: Baoquan He <bhe@redhat.com>

Thanks.

> By the way, a warning need be 'Fixes' tag and back ported to stable
> kernel?

Yup.  I added the cc:stable.


      reply	other threads:[~2026-01-28 19:19 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-28  4:35 [PATCH v2] kexec: derive purgatory entry from symbol Li Chen
2026-01-28  9:26 ` Baoquan He
2026-01-28 19:19   ` Andrew Morton [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260128111929.73a13cc2d51ef113a586993e@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=bhe@redhat.com \
    --cc=chenste@linux.microsoft.com \
    --cc=coxu@redhat.com \
    --cc=ebiggers@kernel.org \
    --cc=graf@amazon.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=me@linux.beauty \
    --cc=prudo@redhat.com \
    --cc=ribalda@chromium.org \
    --cc=rostedt@goodmis.org \
    --cc=sourabhjain@linux.ibm.com \
    --cc=tusharsu@linux.microsoft.com \
    --cc=zohar@linux.ibm.com \
    --cc=zwisler@google.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox