Kexec Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Simon Horman <horms@kernel.org>
To: Pnina Feder <pnina.feder@mobileye.com>
Cc: kexec@lists.infradead.org
Subject: Re: [PATCH 02/10] util_lib: Add vmcoreinfo parser and memory reader
Date: Mon, 20 Jul 2026 10:24:48 +0100	[thread overview]
Message-ID: <20260720092448.GC1736709@horms.kernel.org> (raw)
In-Reply-To: <20260622205550.1087163-3-pnina.feder@mobileye.com>

On Mon, Jun 22, 2026 at 11:54:40PM +0300, Pnina Feder wrote:
> Add the foundational utility libraries for parsing vmcore files:
> 
> - vmcore_info: Parser for vmcoreinfo note section. Supports SYMBOL(),
>   OFFSET(), SIZE(), NUMBER(), LENGTH() lookups via hash table.
>   Provides cached get_page_size()/get_page_shift() accessors.
>   Handles plain KEY=VALUE entries like PAGESIZE and OSRELEASE.
> 
> - memory: Virtual-to-physical address translation dispatcher and
>   readmem() for reading from vmcore via kernel or user virtual
>   addresses, or physical addresses.Uses paddr_to_offset() from
>   elf_info for physical-to-file-offset mapping.
> 
> - vmcore_tasks_util: Shared macros, typedefs, and debug helpers
>   used by vmcore_info and memory (debug verbosity levels, type
>   accessors, __weak definition).
> 
> These files are placed in util_lib/ but are currently only built by
> the vmcore_tasks Makefile. Integration into the main util_lib build
> can be done later if other tools need them.
> 
> Signed-off-by: Pnina Feder <pnina.feder@mobileye.com>

There are whitepsace errors when applying using git am.
Likewise in patch 5/10, 8/10 and 9/10.

I'd appreciate it if you could address that along with
the minor concerns I raised with patch 1/10.

...


  reply	other threads:[~2026-07-20  9:24 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-06-22 20:54 [PATCH 00/10] vmcore-tasks: lightweight task and backtrace extractor for vmcore files Pnina Feder
2026-06-22 20:54 ` [PATCH 01/10] util_lib: add paddr_to_offset function and expose raw vmcoreinfo data Pnina Feder
2026-07-20  9:24   ` Simon Horman
2026-06-22 20:54 ` [PATCH 02/10] util_lib: Add vmcoreinfo parser and memory reader Pnina Feder
2026-07-20  9:24   ` Simon Horman [this message]
2026-06-22 20:54 ` [PATCH 03/10] util_lib: Add maple tree walker for VMA enumeration Pnina Feder
2026-06-22 20:54 ` [PATCH 04/10] vmcore_tasks: Add common definitions and project infrastructure Pnina Feder
2026-06-22 20:54 ` [PATCH 05/10] vmcore_tasks: arch: Add RISC-V 64-bit architecture support Pnina Feder
2026-06-22 20:54 ` [PATCH 06/10] vmcore_tasks: arch: Add MIPS64 " Pnina Feder
2026-06-22 20:54 ` [PATCH 07/10] vmcore_tasks: Add generic user-space stack unwinder Pnina Feder
2026-06-22 20:54 ` [PATCH 08/10] vmcore_tasks: Add VMA utilities and task enumeration Pnina Feder
2026-06-22 20:54 ` [PATCH 09/10] vmcore_tasks: Add main entry point and backtrace parser Pnina Feder
2026-06-22 20:54 ` [PATCH 10/10] vmcore_tasks: Add README with project documentation Pnina Feder
2026-06-22 21:41 ` [PATCH] vmcore-tasks: lightweight task and backtrace extractor for vmcore files Pnina Feder
2026-07-08  7:38 ` [PATCH 00/10] " Pnina Feder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260720092448.GC1736709@horms.kernel.org \
    --to=horms@kernel.org \
    --cc=kexec@lists.infradead.org \
    --cc=pnina.feder@mobileye.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox