From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 4F310C88E7F for ; Tue, 15 Sep 2026 12:05:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:MIME-Version:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=9fBEtIbr3AFyAksoQqS3Fbydy5vpB4nMaKZT39mGc48=; b=3wwrEIGybeIzkpFbaRVNkPYZkp 6qii10imp3TZ2cBaioEjeJczffRKBzZPasgGQm5NayvPQ1zqU26bmXwf0AofO3xOTEt8nJop7b4ak L8mf+x0jB3fx7bNpInAfJSIMNJhOsGXTKLkt/aZvffYGkISquDZCXfTK1YLiuMrQ6ONHqzzyzm6ny z0q6qYjJQeb70Tna8UIrEeTaqsT5VZmm4ASAlqPQrz3IwmNg9F6t0IfvjJWafU/Sw+Y/PJgDjC8DJ X3Y7oJgwvvAjKKZztdJPM6O4VmKw4vepGU82ZHkdnJxiFmgVL580HCmbMijbZSlbDoAJGDyR4L+Bq l5URbeXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6Ruj-00000006Nsp-0sFu; Tue, 15 Sep 2026 12:05:29 +0000 Received: from tor.source.kernel.org ([2600:3c04:e001:324:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x6Rui-00000006NsR-18pL; Tue, 15 Sep 2026 12:05:28 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 618BA60261; Tue, 15 Sep 2026 12:05:27 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4910B1F000FF; Tue, 15 Sep 2026 12:05:25 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789473927; bh=9fBEtIbr3AFyAksoQqS3Fbydy5vpB4nMaKZT39mGc48=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=ciTyjsYio6YcUd6U+CzkUXMFWJVI5JN8YpF3LWAF35D4RcZO6WNyNNLXWTcTNKx/k phMotj0kCSRJiLRwEB6PukDAqeOWTf+ZkB0jp+D5F2leVdFoUNkcjEaKJx1upIioCP CUcHsmrqrKX9GAlkCPX6E26buGa/rDYMQLBRn2YZpYiLqv6kE2OPMZp+B2G/43JgPY VQ3gvXiSdHMDyE74NA/AxGmidg9o/oGBR74v2qXcAt1S74qyth1DbIflVP8V9zvpQm 0rcjVCp5RxoIduGdCiF4608I/waS+6ME56RhQGnLGMkkRdYNrNVYyQVY30p5DEkuKy JPaEc4INykdeQ== From: sashiko-bot@kernel.org Subject: Re: [PATCH RFC POC 25/50] file: reimplement FD_PREPARE() on the deferred fd_prepare() path To: "Linus Torvalds" , "Christian Brauner" Cc: "Jens Axboe" , "Peter Zijlstra" , linux-alpha@vger.kernel.org, linux-kernel@vger.kernel.org, sparclinux@vger.kernel.org, "Michael S. Tsirkin" , linux-mm@kvack.org, linux-hyperv@vger.kernel.org, linux-mips@vger.kernel.org, linux-openrisc@vger.kernel.org, linux-m68k@lists.linux-m68k.org, linuxppc-dev@lists.ozlabs.org, linux-parisc@vger.kernel.org, linux-gpio@vger.kernel.org, virtualization@lists.linux.dev, "Ingo Molnar" , linux-um@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-csky@vger.kernel.org, "Alexander Viro" , bpf@vger.kernel.org, linux-snps-arc@lists.infradead.org, io-uring@vger.kernel.org, =?utf-8?b?Q2hyaXN0aWFuIEJyYXVuZXIgKEFtdXRhYmxlKQ==?= , "Oleg Nesterov" , "Eugenio Perez" , kexec@lists.infradead.org, kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-hexagon@vger.kernel.org, linux-arm-msm@vger.kernel.org, "Jann Horn" , "David Airlie" , linux-sh@vger.kernel.org, "Jan Kara" , linux-fsdevel@vger.kernel.org In-Reply-To: <20260915-work-fd-reserve-unify-folded-v1-25-4d5217d6b246@kernel.org> References: <20260915-work-fd-reserve-unify-folded-v1-0-4d5217d6b246@kernel.org> <20260915-work-fd-reserve-unify-folded-v1-25-4d5217d6b246@kernel.org> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Tue, 15 Sep 2026 12:05:24 +0000 Message-Id: <20260915120525.4910B1F000FF@smtp.kernel.org> X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org > The FD_PREPARE() cleanup class allocated and installed immediately and > required fd_publish() to be the last thing that could fail. Reimplement > it on the deferred path. FD_PREPARE() reserves a slot with fd_prepare() > and stages the file on it. The syscall exit installs on success and > drops on error. fd_prepare_fd() and fd_prepare_file() now read the slot. > fd_publish() is gone. >=20 > Convert every FD_PREPARE() user since fdf.err can now become a simple > IS_ERR(fdf). >=20 > Signed-off-by: Christian Brauner (Amutable) Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260915-work-fd-re= serve-unify-folded-v1-0-4d5217d6b246@kernel.org?part=3D25