From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id DE420C982D2 for ; Thu, 17 Sep 2026 16:47:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:MIME-Version:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=LAxtjYEua4plusINVTHcMgxVKXWmoP1/pA9iq8tgzLI=; b=0bHv6NnAwzJhvH2g3FKorf+2Zi TYbmuOLdOlQALB5AYrur/KBvRELHrN2vwQ4O5f/iqESX/GaJrCLetyJorFjPhlm+zvFyBK+JScnwb K9AeW5P6LSqcDwEuYNF1ccRtY+OnlNBNl507aASHyyFm7t+SBJnbAVvxWjYD2zULBKGI6I5sE9gyr T3iFWW/QbeMGuODSZnE808NnX0Jn3ZkhqwY51AmHGXv9YVd0Jq9/v7N8D3Yk0CscvzjvX1vKnzDFk wO00laCR9XYwjUGp+8J0O5H1OTKpZhqYANQJOpI4JSNcc5qC4hBKpynTBzZ+AR/locsBx0Ctjicld tOFLvkxg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7FHB-0000000BzIp-2ZPH; Thu, 17 Sep 2026 16:47:57 +0000 Received: from tor.source.kernel.org ([172.105.4.254]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1x7FHB-0000000BzIU-06N1 for kexec@lists.infradead.org; Thu, 17 Sep 2026 16:47:57 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by tor.source.kernel.org (Postfix) with ESMTP id 782E7601F1; Thu, 17 Sep 2026 16:47:56 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 3566C1F00893; Thu, 17 Sep 2026 16:47:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1789663676; bh=LAxtjYEua4plusINVTHcMgxVKXWmoP1/pA9iq8tgzLI=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=nTitcEIWbzlk+odPQnUeF0nJT6d5yWSXoqf8KNtrfF7Wtkxu5OSj8RUQdw61PuRgp IGYQ3h+rYgG17SJbxNWCOVMhLGJUdCuxI8FuU0Vt5UQO22rxZJxgBBZCVxJmFhlT5r cxi7DBGLJv681mS5YesTDO5zvdKjf2SB9C4Ez8p7h5uJ2KAeyAnFWEXhypXXy4rQeh GaMUcctlOEyWUpd/EfPmiQX5fVrEKaNY8ChfrNau4xL1n1BKYiLbw7YCGSslZK1556 z0np5252lOVT/84rVd2yStnO8p0SomjB87tVT1h2TIoc+0sjjMseKtgdyB4MxwLWBe 8HQcdSOR/zT/A== From: sashiko-bot@kernel.org Subject: Re: [PATCH 3/9] driver core: warn should device_move try to move a need_parent_lock device To: "Rafael J. Wysocki" , "Danilo Krummrich" , "Greg Kroah-Hartman" , "David Jeffery" , driver-core@lists.linux.dev Cc: linux-pci@vger.kernel.org, "Stuart Hayes" , "Laurence Oberman" , "John Meneghini" , "Martin K . Petersen" , "Pasha Tatashin" , "Ewan Milne" , "John Garry" , "Bart Van Assche" , "Tarun Sahu" , linux-kernel@vger.kernel.org, kexec@lists.infradead.org, Maurizio , "Jeremy Allison" , linux-scsi@vger.kernel.org, "Bjorn Helgaas" In-Reply-To: <20260917163744.191748-4-djeffery@redhat.com> References: <20260917163744.191748-1-djeffery@redhat.com> <20260917163744.191748-4-djeffery@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Thu, 17 Sep 2026 16:47:54 +0000 Message-Id: <20260917164755.3566C1F00893@smtp.kernel.org> X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" Errors-To: kexec-bounces+kexec=archiver.kernel.org@lists.infradead.org > Currently, no device has need_parent_lock set and is moved by > device_move. need_parent_lock is only set by the usb bus and very > few device types ever use device_move. >=20 > Add a warning to device_move to catch should it ever be used on a > device with need_parent_lock set. The combination would break > the immutable relationship needed between parent and child for > need_parent_lock when locking and unlocking both. >=20 > Suggested-by: Tarun Sahu > Signed-off-by: David Jeffery Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260917163744.1917= 48-1-djeffery@redhat.com?part=3D3