From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0804A606A324 for ; Tue, 20 Oct 2026 08:21:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=lists.infradead.org header.i=@lists.infradead.org header.a=rsa-sha256 header.s=bombadil.20210309 header.b=io0Fo7Kw; dkim=pass (2048-bit key, unprotected) header.d=kernel.org header.i=@kernel.org header.a=rsa-sha256 header.s=k20260515 header.b=EXIu9dO6 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Reply-To:List-Subscribe: List-Help:List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date: Content-Transfer-Encoding:Content-Type:References:In-Reply-To:Cc:To:Subject: From:MIME-Version:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Rv/LkB6PetOdVT/pJO5A17DkMHpW1BtDQRc+jBFVZPw=; b=io0Fo7Kwv2s24DuxPMz++WU34h QnwhY2Yhj8FG/49RFzzqt1IQIvC1aH76Qw9JYTi0GD51cMNzKELEspw2k5I/a6vAAKE8CM4IpS3pA 8Eg0sSXXba1fdZVn+IKVxzXI28ICnx9xX3QQu/HElF+w/zd4edUjO6OPP+iyebah10YCu06QX2eMm w8Dz95Qh84MNjoa9OX1Cslx/Lfmzw5PCbyQc4+7XnvXkRBxQ4XvX6kQfbqT+a4/VQzHDiwodLGcUe 4AySoJMjWLdNyLM+Phgr9rfASeUj4/pCylDCkZnZ/xCUk5CEUVEzopcEsbg7ruTIiQJCHVyq43I/B DCiKL44w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.99.1 #2 (Red Hat Linux)) id 1xJ56K-000000099V1-0nSe; Tue, 20 Oct 2026 08:21:40 +0000 Received: from sea.source.kernel.org ([2600:3c0a:e001:78e:0:1991:8:25]) by bombadil.infradead.org with esmtps (Exim 4.99.1 #2 (Red Hat Linux)) id 1xBFEm-00000001Az4-2VvV; Mon, 28 Sep 2026 17:34:00 +0000 Received: from smtp.kernel.org (quasi.space.kernel.org [100.103.45.18]) by sea.source.kernel.org (Postfix) with ESMTP id 05C5843995; Mon, 28 Sep 2026 17:34:00 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id B7E641F000FF; Mon, 28 Sep 2026 17:33:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel.org; s=k20260515; t=1790616839; bh=Rv/LkB6PetOdVT/pJO5A17DkMHpW1BtDQRc+jBFVZPw=; h=From:Subject:Reply-To:To:Cc:In-Reply-To:References:Date; b=EXIu9dO6xq2mXjLluKTuv30Af8CyESirOON3Mf9f2hlYpl04nw+40wD3YbPZG1tfL HmEUK5JSYhOyLVpaITSvM4ELC305cnUmqN9ksJ+i7mccp6EtQ/LsYNrSRewyr85nde fVJV76IlrsFhWqVs/3xmVmIBd5rfId8R3Lh7oVvN7+x6UaAjI/u56vaUwWNH+BzmMd 5K4imrySj0RLN+5w4QO4+sSnSj9TmSjJF2l8B8t3RQ3nGTFBARSJ9FwuxizUmBvtrv QDRybDY6Goyif08lGnOWdctOSDJJJnyLsuwJCiGm2H3dSjfMBA31RN52rTusPsKHOf pnr0NyfPsRKJg== From: sashiko-bot@kernel.org Subject: Re: [PATCH v3 05/12] dm crypt: Allocate key material from the secret pool To: "Usama Arif" , "Matthew Brost" , "Byungchul Park" , "Harry Yoo" , "Dave Young" , "Will Deacon" , "David Howells" , "Andrew Morton" , "Mark Rutland" , "Kiryl Shutsemau" , "Dev Jain" , "Johannes Weiner" , "Mikulas Patocka" , "Ryan Roberts" , "Peter Xu" , "David S. Miller" , "Vlastimil Babka" , "David Hildenbrand" , "Shuah Khan" , "James Morris" , "Lorenzo Stoakes" , "Jann Horn" , "Alistair Popple" , "Saravana Kannan" , "Serge E. Hallyn" , "Lance Yang" , "Barry Song" , "Oscar Salvador" , "Ying Huang" , "Randy Dunlap" , "Mimi Zohar" , "Muchun Song" , "Catalin Marinas" , "Herbert Xu" , "Brendan Jackman" , "Gregory Price" , "Baolin Wang" , "Danilo Krummrich" , "Arnd Bergmann" , "Mike Rapoport" , "James Bottomley" , "Pratyush Yadav" , "Michal Hocko" , "Liam R. Howlett" , "Rik van Riel" , "Greg Kroah-Hartman" , "Nico Pache" , =?utf-8?b?SmFuIFNlYmFzdGlhbiBHw7Z0dGU=?= , "Mike Snitzer" , "Pasha Tatashin" , "Rafael J. Wysocki" , "Paul Moore" , "Pedro Falcato" , "Baoquan He" , "Suren Baghdasaryan" , "Alasdair Kergon" , "Zi Yan" , "Jonathan Corbet" , "Rob Herring" , "Joshua Hahn" , "Benjamin Marzinski" , "Jarkko Sakkinen" Cc: linux-crypto@vger.kernel.org, linux-integrity@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, conor+dt@kernel.org, driver-core@lists.linux.dev, linux-arm-kernel@lists.infradead.org, robh@kernel.org, linux-security-module@vger.kernel.org, kexec@lists.infradead.org, keyrings@vger.kernel.org, linux-arch@vger.kernel.org, devicetree@vger.kernel.org, linux-fsdevel@vger.kernel.org, "Eric Biggers" , linux-kernel@vger.kernel.org, dm-devel@lists.linux.dev In-Reply-To: <20260928-crash-memaction-upstream-20260921-v3-5-e511e9ee2329@jaseg.de> References: <20260928-crash-memaction-upstream-20260921-v3-0-e511e9ee2329@jaseg.de> <20260928-crash-memaction-upstream-20260921-v3-5-e511e9ee2329@jaseg.de> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Date: Mon, 28 Sep 2026 17:33:55 +0000 Message-Id: <20260928173355.B7E641F000FF@smtp.kernel.org> X-Mailman-Approved-At: Tue, 20 Oct 2026 01:21:10 -0700 X-BeenThere: kexec@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: sashiko-reviews@lists.linux.dev Sender: "kexec" X-Spam-Status: No, score=-11.2 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=4.0.1 X-Spam-Checker-Version: SpamAssassin 4.0.1 (2024-03-26) on aws-us-west-2-korg-listserv-alma10-1 X-Archived-By: > dm-crypt keeps the volume key, the IV mode seeds and, when a keyring key > is used, the key description in memory for as long as the target exists. > If the system crashes, they are left in memory and will end up in a > crash dump. >=20 > Allocate every buffer that holds key material from the new secret pool, > whose backing pages are marked by crash_memaction for the kdump kernel > to wipe. The volume key is a flexible array at the end of struct > crypt_config, so the whole struct moves into the pool with it. >=20 > Signed-off-by: Jan Sebastian G=C3=B6tte Sashiko has reviewed this patch and found no issues. It looks great! --=20 Sashiko AI review =C2=B7 https://sashiko.dev/#/patchset/20260928-crash-mema= ction-upstream-20260921-v3-0-e511e9ee2329@jaseg.de?part=3D5