From: Pratyush Anand <panand@redhat.com>
To: Cong Wang <xiyou.wangcong@gmail.com>, kexec@lists.infradead.org
Cc: horms@verge.net.au
Subject: Re: [PATCH] vmcore-dmesg: avoid allocating large memory chunk for log buf
Date: Wed, 28 Jun 2017 10:57:58 +0530 [thread overview]
Message-ID: <2550dd3e-4473-aef8-41cf-4bfe1bb930df@redhat.com> (raw)
In-Reply-To: <1497910994-15129-1-git-send-email-xiyou.wangcong@gmail.com>
On Tuesday 20 June 2017 03:53 AM, Cong Wang wrote:
> In kdump kernel, we got:
>
> Saving vmcore-dmesg.txt
> Failed to malloc 67108864 bytes for the logbuf: Cannot allocate memory
>
> Apparently 64M is too luxury for a kdump kernel which only has 128M
> in total.
>
> We can avoid allocating such a large memory chunk, instead just allocate
> a smaller chunk inside the loop each time.
Nice improvement.
>
> Verify the result by comparing the vmcore-dmesg output with and without
> this patch.
Yes, it works.
Modification looks fine to me.
Reviewed-by: Pratyush Anand <panand@redhat.com>
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
prev parent reply other threads:[~2017-06-28 5:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-19 22:23 [PATCH] vmcore-dmesg: avoid allocating large memory chunk for log buf Cong Wang
2017-06-27 16:43 ` Cong Wang
2017-06-28 5:19 ` Dave Young
2017-07-05 17:18 ` Cong Wang
2017-06-28 5:27 ` Pratyush Anand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2550dd3e-4473-aef8-41cf-4bfe1bb930df@redhat.com \
--to=panand@redhat.com \
--cc=horms@verge.net.au \
--cc=kexec@lists.infradead.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox