From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ozlabs.org ([203.10.76.45]) by canuck.infradead.org with esmtps (Exim 4.63 #1 (Red Hat Linux)) id 1HvMPh-0005YY-Mf for kexec@lists.infradead.org; Mon, 04 Jun 2007 19:56:42 -0400 From: Michael Neuling Subject: Re: [PATCH] kexec ppc64: fix misaligned cmdline In-reply-to: <20070604234917.GB10877@localhost.localdomain> References: <25445.1180941825@neuling.org> <20070604234917.GB10877@localhost.localdomain> Date: Tue, 05 Jun 2007 09:56:37 +1000 Message-ID: <2554.1181001397@neuling.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org+dwmw2=infradead.org@lists.infradead.org To: David Gibson Cc: linuxppc-dev@ozlabs.org, horms@verge.net.au, kexec@lists.infradead.org, miltonm@bga.com > > If the cmdline changes between boots, we can get misalignment of the > > bootargs entry, which in turn corrupts our device tree blob and hence > > kills our kexec boot. > > > > Specifically, if the cmdline length was >= 8 before and the new cmdline > > length is < 8, we can get corruption. > > Hrm. Have you considered using dtc for this conversion, rather than > this somewhat dubious looking fs2dt? Numerous times. fs2dt needs to be converted to use the device tree library, but that will take a lot more work than a 5 minute patch. Mikey _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec