From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from ozlabs.org ([203.10.76.45]) by canuck.infradead.org with esmtps (Exim 4.63 #1 (Red Hat Linux)) id 1HvUJ8-00036P-EP for kexec@lists.infradead.org; Tue, 05 Jun 2007 04:22:29 -0400 From: Michael Neuling Subject: root= cmdline modification in kexec (was Re: [PATCH] kexec ppc64: fix misaligned cmdline ) In-reply-to: <26608.1180950136@neuling.org> References: <25445.1180941825@neuling.org> <8f5d8a214e9042b0c556ac7256928a52@bga.com> <26608.1180950136@neuling.org> Date: Tue, 05 Jun 2007 18:22:18 +1000 Message-ID: <2773.1181031738@neuling.org> List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: kexec-bounces@lists.infradead.org Errors-To: kexec-bounces+dwmw2=infradead.org+dwmw2=infradead.org@lists.infradead.org To: horms@verge.net.au, kexec@lists.infradead.org, miltonm@bga.com > > While this appears to fix the stated problem, did you explore my > > suggestion of deleting and creating the property like we do for > > the initrd base and size? > > Yeah, but it didn't seem "hapazard" enough for kexec. :-) > > > Deleting and recreating should also handle the case of no boot-args in > > the original /chosen sub-tree (when the bootloader didn't (need to) > > supply a command line). > > Yeah, we're screwed when the first boot has no bootargs. > > Let me get the policy right. We blow away the old command line except > for the "root=blah" item. Correct? OK Looks like we parse the new command line to see if there is a 'root=blah' parameter. If yes, use that, otherwise we use what was on the last boot. Is this what other architectures are doing? Is there any other special cases we need to look out for? Mikey _______________________________________________ kexec mailing list kexec@lists.infradead.org http://lists.infradead.org/mailman/listinfo/kexec